From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH] drm: Drop owner assignment from i2c_driver Date: Fri, 10 Jul 2015 16:01:10 +0900 Message-ID: <559F6DB6.9010000@samsung.com> References: <1436506597-1096-1-git-send-email-k.kozlowski@samsung.com> <1436506597-1096-2-git-send-email-k.kozlowski@samsung.com> <559F6B3C.8080908@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-reply-to: <559F6B3C.8080908@rock-chips.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Mark yao , David Airlie , Heiko Stuebner , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org T24gMTAuMDcuMjAxNSAxNTo1MCwgTWFyayB5YW8gd3JvdGU6Cj4gT24gMjAxNeW5tDA35pyIMTDm l6UgMTM6MzYsIEtyenlzenRvZiBLb3psb3dza2kgd3JvdGU6Cj4+IGkyY19kcml2ZXIgZG9lcyBu b3QgbmVlZCB0byBzZXQgYW4gb3duZXIgYmVjYXVzZSBpMmNfcmVnaXN0ZXJfZHJpdmVyKCkKPj4g d2lsbCBzZXQgaXQuCj4+Cj4+IFNpZ25lZC1vZmYtYnk6IEtyenlzenRvZiBLb3psb3dza2kgPGsu a296bG93c2tpQHNhbXN1bmcuY29tPgo+Pgo+PiAtLS0KPj4KPj4gVGhlIGNvY2NpbmVsbGUgc2Ny aXB0IHdoaWNoIGdlbmVyYXRlZCB0aGUgcGF0Y2ggd2FzIHNlbnQgaGVyZToKPj4gaHR0cDovL3d3 dy5zcGluaWNzLm5ldC9saXN0cy9rZXJuZWwvbXNnMjAyOTkwMy5odG1sCj4+IC0tLQo+PiAgIGRy aXZlcnMvZ3B1L2RybS9icmlkZ2UvcHM4NjIyLmMgICAgICAgICAgICAgfCAxIC0KPj4gICBkcml2 ZXJzL2dwdS9kcm0vYnJpZGdlL3B0bjM0NjAuYyAgICAgICAgICAgIHwgMSAtCj4+ICAgZHJpdmVy cy9ncHUvZHJtL3JvY2tjaGlwL3JvY2tjaGlwX2RybV9kcnYuYyB8IDEgLQo+PiAgIDMgZmlsZXMg Y2hhbmdlZCwgMyBkZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9icmlkZ2UvcHM4NjIyLmMKPj4gYi9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL3BzODYyMi5jCj4+ IGluZGV4IDFhNjYwN2JlYjI5Zi4uYmU4ODFlOWZlZjhmIDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vYnJpZGdlL3BzODYyMi5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2Uv cHM4NjIyLmMKPj4gQEAgLTY2OCw3ICs2NjgsNiBAQCBzdGF0aWMgc3RydWN0IGkyY19kcml2ZXIg cHM4NjIyX2RyaXZlciA9IHsKPj4gICAgICAgLnJlbW92ZSAgICAgICAgPSBwczg2MjJfcmVtb3Zl LAo+PiAgICAgICAuZHJpdmVyICAgICAgICA9IHsKPj4gICAgICAgICAgIC5uYW1lICAgID0gInBz ODYyMiIsCj4+IC0gICAgICAgIC5vd25lciAgICA9IFRISVNfTU9EVUxFLAo+PiAgICAgICAgICAg Lm9mX21hdGNoX3RhYmxlID0gcHM4NjIyX2RldmljZXMsCj4+ICAgICAgIH0sCj4+ICAgfTsKPj4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvcHRuMzQ2MC5jCj4+IGIvZHJpdmVy cy9ncHUvZHJtL2JyaWRnZS9wdG4zNDYwLmMKPj4gaW5kZXggMWIxYmYyMzg0ODE1Li4wZmZhM2E2 YTIwNmEgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvcHRuMzQ2MC5jCj4+ ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvcHRuMzQ2MC5jCj4+IEBAIC00MDAsNyArNDAw LDYgQEAgc3RhdGljIHN0cnVjdCBpMmNfZHJpdmVyIHB0bjM0NjBfZHJpdmVyID0gewo+PiAgICAg ICAucmVtb3ZlICAgICAgICA9IHB0bjM0NjBfcmVtb3ZlLAo+PiAgICAgICAuZHJpdmVyICAgICAg ICA9IHsKPj4gICAgICAgICAgIC5uYW1lICAgID0gIm54cCxwdG4zNDYwIiwKPj4gLSAgICAgICAg Lm93bmVyICAgID0gVEhJU19NT0RVTEUsCj4+ICAgICAgICAgICAub2ZfbWF0Y2hfdGFibGUgPSBw dG4zNDYwX21hdGNoLAo+PiAgICAgICB9LAo+PiAgIH07Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vcm9ja2NoaXAvcm9ja2NoaXBfZHJtX2Rydi5jCj4+IGIvZHJpdmVycy9ncHUvZHJt L3JvY2tjaGlwL3JvY2tjaGlwX2RybV9kcnYuYwo+PiBpbmRleCAwMWI1NThmZTM2OTUuLjlhMGMy OTExMjcyYSAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL3JvY2tjaGlw X2RybV9kcnYuYwo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvcm9ja2NoaXBfZHJt X2Rydi5jCj4+IEBAIC01NTUsNyArNTU1LDYgQEAgc3RhdGljIHN0cnVjdCBwbGF0Zm9ybV9kcml2 ZXIKPj4gcm9ja2NoaXBfZHJtX3BsYXRmb3JtX2RyaXZlciA9IHsKPj4gICAgICAgLnByb2JlID0g cm9ja2NoaXBfZHJtX3BsYXRmb3JtX3Byb2JlLAo+PiAgICAgICAucmVtb3ZlID0gcm9ja2NoaXBf ZHJtX3BsYXRmb3JtX3JlbW92ZSwKPj4gICAgICAgLmRyaXZlciA9IHsKPj4gLSAgICAgICAgLm93 bmVyID0gVEhJU19NT0RVTEUsCj4gCj4gQnV0IHJvY2tjaGlwIGRybSBpcyBwbGF0Zm9ybSBkcml2 ZXIgbm90IGkyY19kcml2ZXIsIHdoeSByZW1vdmUgaXRzIC5vd25lciA/CgpPaCwgaW5kZWVkLiBU aGFua3MgZm9yIHNwb3R0aW5nIHRoaXMuCgpUaGUgJ293bmVyJyBpcyBzZXQgYnkgY29yZSBmb3Ig cGxhdGZvcm0gZHJpdmVycyBhcyB3ZWxsLiBNb3N0IHBsYXRmb3JtCmRyaXZlcnMgd2VyZSBhbHJl YWR5IGNvbnZlcnRlZCAoSSB0aGluayBieSBXb2xmcmFtIFNhbmcpLiBJIGV4dGVuZGVkCmV4aXN0 aW5nIGNvY2NpbmVsbGUgc2NyaXB0IHRvIGZpeCBhbHNvIGkyY19kcml2ZXJzIGFuZCBzb21ldGlt ZXMgZGlkIG5vdApub3RpY2UgdGhhdCBpdCB3YXMgcGxhdGZvcm1fZHJpdmVyLgoKSSBjYW4gc3Bs aXQgaXQgaW50byB0d28gZGlmZmVyZW50IHBhdGNoZXMuIFdvdWxkIHRoYXQgYmUgb2s/CgpCZXN0 IHJlZ2FyZHMsCktyenlzenRvZgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9k cmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: k.kozlowski@samsung.com (Krzysztof Kozlowski) Date: Fri, 10 Jul 2015 16:01:10 +0900 Subject: [PATCH] drm: Drop owner assignment from i2c_driver In-Reply-To: <559F6B3C.8080908@rock-chips.com> References: <1436506597-1096-1-git-send-email-k.kozlowski@samsung.com> <1436506597-1096-2-git-send-email-k.kozlowski@samsung.com> <559F6B3C.8080908@rock-chips.com> Message-ID: <559F6DB6.9010000@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 10.07.2015 15:50, Mark yao wrote: > On 2015?07?10? 13:36, Krzysztof Kozlowski wrote: >> i2c_driver does not need to set an owner because i2c_register_driver() >> will set it. >> >> Signed-off-by: Krzysztof Kozlowski >> >> --- >> >> The coccinelle script which generated the patch was sent here: >> http://www.spinics.net/lists/kernel/msg2029903.html >> --- >> drivers/gpu/drm/bridge/ps8622.c | 1 - >> drivers/gpu/drm/bridge/ptn3460.c | 1 - >> drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 1 - >> 3 files changed, 3 deletions(-) >> >> diff --git a/drivers/gpu/drm/bridge/ps8622.c >> b/drivers/gpu/drm/bridge/ps8622.c >> index 1a6607beb29f..be881e9fef8f 100644 >> --- a/drivers/gpu/drm/bridge/ps8622.c >> +++ b/drivers/gpu/drm/bridge/ps8622.c >> @@ -668,7 +668,6 @@ static struct i2c_driver ps8622_driver = { >> .remove = ps8622_remove, >> .driver = { >> .name = "ps8622", >> - .owner = THIS_MODULE, >> .of_match_table = ps8622_devices, >> }, >> }; >> diff --git a/drivers/gpu/drm/bridge/ptn3460.c >> b/drivers/gpu/drm/bridge/ptn3460.c >> index 1b1bf2384815..0ffa3a6a206a 100644 >> --- a/drivers/gpu/drm/bridge/ptn3460.c >> +++ b/drivers/gpu/drm/bridge/ptn3460.c >> @@ -400,7 +400,6 @@ static struct i2c_driver ptn3460_driver = { >> .remove = ptn3460_remove, >> .driver = { >> .name = "nxp,ptn3460", >> - .owner = THIS_MODULE, >> .of_match_table = ptn3460_match, >> }, >> }; >> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c >> b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c >> index 01b558fe3695..9a0c2911272a 100644 >> --- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c >> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c >> @@ -555,7 +555,6 @@ static struct platform_driver >> rockchip_drm_platform_driver = { >> .probe = rockchip_drm_platform_probe, >> .remove = rockchip_drm_platform_remove, >> .driver = { >> - .owner = THIS_MODULE, > > But rockchip drm is platform driver not i2c_driver, why remove its .owner ? Oh, indeed. Thanks for spotting this. The 'owner' is set by core for platform drivers as well. Most platform drivers were already converted (I think by Wolfram Sang). I extended existing coccinelle script to fix also i2c_drivers and sometimes did not notice that it was platform_driver. I can split it into two different patches. Would that be ok? Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753276AbbGJHBO (ORCPT ); Fri, 10 Jul 2015 03:01:14 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:10924 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752650AbbGJHBI (ORCPT ); Fri, 10 Jul 2015 03:01:08 -0400 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: cbfec7f4-f79c56d0000012ee-a0-559f6db1a77d Content-transfer-encoding: 8BIT Message-id: <559F6DB6.9010000@samsung.com> Date: Fri, 10 Jul 2015 16:01:10 +0900 From: Krzysztof Kozlowski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 To: Mark yao , David Airlie , Heiko Stuebner , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH] drm: Drop owner assignment from i2c_driver References: <1436506597-1096-1-git-send-email-k.kozlowski@samsung.com> <1436506597-1096-2-git-send-email-k.kozlowski@samsung.com> <559F6B3C.8080908@rock-chips.com> In-reply-to: <559F6B3C.8080908@rock-chips.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrFLMWRmVeSWpSXmKPExsVy+t/xy7qbcueHGnROYbToPXeSyeLK1/ds Fv8fvWa1eP3C0GLT42usFpd3zWGz+PTgP7PFjikHmBw4PLZ/e8Dqcb/7OJPH5iX1Hn9n7Wfx 6NuyitFj+7V5zB6fN8kFsEdx2aSk5mSWpRbp2yVwZcy+d4i1YJlIxaKeTUwNjB/5uxg5OSQE TCQu3nvBDGGLSVy4t56ti5GLQ0hgKaPEv83LGEESvAKCEj8m32PpYuTgYBaQlzhyKRvCVJeY MiUXpEJI4CmjxLoFzBDVWhL/5v0B62QRUJW48PEUO4jNJmAssXn5EjYQW1QgQuLt5ZNMIKtE BH4Ardr9gxUkISxgL7Gm8STUDcsZJdbffQXWzSmgJ7G97R/LBEb+WUhOmoVw0iyEkxYwMq9i FE0tTS4oTkrPNdQrTswtLs1L10vOz93ECAnxLzsYFx+zOsQowMGoxMMbwDY/VIg1say4MvcQ owQHs5IIL78EUIg3JbGyKrUoP76oNCe1+BCjNAeLkjjv3F3vQ4QE0hNLUrNTUwtSi2CyTByc Ug2Mmqae0Ye3ZQdE5XLtvWTaM//SVfXWnaaz9wY7eh2ZHtDo1yb6dnrO7439iTH3YzYrhvLu zEtMkSzkenlxqcwq6Vv8m1Yc5DLW62Qx/HZzzTF1ltkdFYx2q3XOVO7mYf3t/8T1b3O0Y1wa 06mnTMyu3BrplzaaTfuy4vhJVrEZT7if1fWefn9QiaU4I9FQi7moOBEANiclKm0CAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10.07.2015 15:50, Mark yao wrote: > On 2015年07月10日 13:36, Krzysztof Kozlowski wrote: >> i2c_driver does not need to set an owner because i2c_register_driver() >> will set it. >> >> Signed-off-by: Krzysztof Kozlowski >> >> --- >> >> The coccinelle script which generated the patch was sent here: >> http://www.spinics.net/lists/kernel/msg2029903.html >> --- >> drivers/gpu/drm/bridge/ps8622.c | 1 - >> drivers/gpu/drm/bridge/ptn3460.c | 1 - >> drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 1 - >> 3 files changed, 3 deletions(-) >> >> diff --git a/drivers/gpu/drm/bridge/ps8622.c >> b/drivers/gpu/drm/bridge/ps8622.c >> index 1a6607beb29f..be881e9fef8f 100644 >> --- a/drivers/gpu/drm/bridge/ps8622.c >> +++ b/drivers/gpu/drm/bridge/ps8622.c >> @@ -668,7 +668,6 @@ static struct i2c_driver ps8622_driver = { >> .remove = ps8622_remove, >> .driver = { >> .name = "ps8622", >> - .owner = THIS_MODULE, >> .of_match_table = ps8622_devices, >> }, >> }; >> diff --git a/drivers/gpu/drm/bridge/ptn3460.c >> b/drivers/gpu/drm/bridge/ptn3460.c >> index 1b1bf2384815..0ffa3a6a206a 100644 >> --- a/drivers/gpu/drm/bridge/ptn3460.c >> +++ b/drivers/gpu/drm/bridge/ptn3460.c >> @@ -400,7 +400,6 @@ static struct i2c_driver ptn3460_driver = { >> .remove = ptn3460_remove, >> .driver = { >> .name = "nxp,ptn3460", >> - .owner = THIS_MODULE, >> .of_match_table = ptn3460_match, >> }, >> }; >> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c >> b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c >> index 01b558fe3695..9a0c2911272a 100644 >> --- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c >> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c >> @@ -555,7 +555,6 @@ static struct platform_driver >> rockchip_drm_platform_driver = { >> .probe = rockchip_drm_platform_probe, >> .remove = rockchip_drm_platform_remove, >> .driver = { >> - .owner = THIS_MODULE, > > But rockchip drm is platform driver not i2c_driver, why remove its .owner ? Oh, indeed. Thanks for spotting this. The 'owner' is set by core for platform drivers as well. Most platform drivers were already converted (I think by Wolfram Sang). I extended existing coccinelle script to fix also i2c_drivers and sometimes did not notice that it was platform_driver. I can split it into two different patches. Would that be ok? Best regards, Krzysztof