From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark yao Subject: Re: [PATCH] drm: Drop owner assignment from i2c_driver Date: Fri, 10 Jul 2015 15:11:35 +0800 Message-ID: <559F7027.6010602@rock-chips.com> References: <1436506597-1096-1-git-send-email-k.kozlowski@samsung.com> <1436506597-1096-2-git-send-email-k.kozlowski@samsung.com> <559F6B3C.8080908@rock-chips.com> <559F6DB6.9010000@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <559F6DB6.9010000@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Krzysztof Kozlowski , David Airlie , Heiko Stuebner , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org T24gMjAxNeW5tDA35pyIMTDml6UgMTU6MDEsIEtyenlzenRvZiBLb3psb3dza2kgd3JvdGU6Cj4g T24gMTAuMDcuMjAxNSAxNTo1MCwgTWFyayB5YW8gd3JvdGU6Cj4+IE9uIDIwMTXlubQwN+aciDEw 5pelIDEzOjM2LCBLcnp5c3p0b2YgS296bG93c2tpIHdyb3RlOgo+Pj4gaTJjX2RyaXZlciBkb2Vz IG5vdCBuZWVkIHRvIHNldCBhbiBvd25lciBiZWNhdXNlIGkyY19yZWdpc3Rlcl9kcml2ZXIoKQo+ Pj4gd2lsbCBzZXQgaXQuCj4+Pgo+Pj4gU2lnbmVkLW9mZi1ieTogS3J6eXN6dG9mIEtvemxvd3Nr aSA8ay5rb3psb3dza2lAc2Ftc3VuZy5jb20+Cj4+Pgo+Pj4gLS0tCj4+Pgo+Pj4gVGhlIGNvY2Np bmVsbGUgc2NyaXB0IHdoaWNoIGdlbmVyYXRlZCB0aGUgcGF0Y2ggd2FzIHNlbnQgaGVyZToKPj4+ IGh0dHA6Ly93d3cuc3Bpbmljcy5uZXQvbGlzdHMva2VybmVsL21zZzIwMjk5MDMuaHRtbAo+Pj4g LS0tCj4+PiAgICBkcml2ZXJzL2dwdS9kcm0vYnJpZGdlL3BzODYyMi5jICAgICAgICAgICAgIHwg MSAtCj4+PiAgICBkcml2ZXJzL2dwdS9kcm0vYnJpZGdlL3B0bjM0NjAuYyAgICAgICAgICAgIHwg MSAtCj4+PiAgICBkcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvcm9ja2NoaXBfZHJtX2Rydi5jIHwg MSAtCj4+PiAgICAzIGZpbGVzIGNoYW5nZWQsIDMgZGVsZXRpb25zKC0pCj4+Pgo+Pj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvcHM4NjIyLmMKPj4+IGIvZHJpdmVycy9ncHUv ZHJtL2JyaWRnZS9wczg2MjIuYwo+Pj4gaW5kZXggMWE2NjA3YmViMjlmLi5iZTg4MWU5ZmVmOGYg MTAwNjQ0Cj4+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL3BzODYyMi5jCj4+PiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL3BzODYyMi5jCj4+PiBAQCAtNjY4LDcgKzY2OCw2IEBA IHN0YXRpYyBzdHJ1Y3QgaTJjX2RyaXZlciBwczg2MjJfZHJpdmVyID0gewo+Pj4gICAgICAgIC5y ZW1vdmUgICAgICAgID0gcHM4NjIyX3JlbW92ZSwKPj4+ICAgICAgICAuZHJpdmVyICAgICAgICA9 IHsKPj4+ICAgICAgICAgICAgLm5hbWUgICAgPSAicHM4NjIyIiwKPj4+IC0gICAgICAgIC5vd25l ciAgICA9IFRISVNfTU9EVUxFLAo+Pj4gICAgICAgICAgICAub2ZfbWF0Y2hfdGFibGUgPSBwczg2 MjJfZGV2aWNlcywKPj4+ICAgICAgICB9LAo+Pj4gICAgfTsKPj4+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vYnJpZGdlL3B0bjM0NjAuYwo+Pj4gYi9kcml2ZXJzL2dwdS9kcm0vYnJpZGdl L3B0bjM0NjAuYwo+Pj4gaW5kZXggMWIxYmYyMzg0ODE1Li4wZmZhM2E2YTIwNmEgMTAwNjQ0Cj4+ PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL3B0bjM0NjAuYwo+Pj4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL2JyaWRnZS9wdG4zNDYwLmMKPj4+IEBAIC00MDAsNyArNDAwLDYgQEAgc3RhdGlj IHN0cnVjdCBpMmNfZHJpdmVyIHB0bjM0NjBfZHJpdmVyID0gewo+Pj4gICAgICAgIC5yZW1vdmUg ICAgICAgID0gcHRuMzQ2MF9yZW1vdmUsCj4+PiAgICAgICAgLmRyaXZlciAgICAgICAgPSB7Cj4+ PiAgICAgICAgICAgIC5uYW1lICAgID0gIm54cCxwdG4zNDYwIiwKPj4+IC0gICAgICAgIC5vd25l ciAgICA9IFRISVNfTU9EVUxFLAo+Pj4gICAgICAgICAgICAub2ZfbWF0Y2hfdGFibGUgPSBwdG4z NDYwX21hdGNoLAo+Pj4gICAgICAgIH0sCj4+PiAgICB9Owo+Pj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9yb2NrY2hpcC9yb2NrY2hpcF9kcm1fZHJ2LmMKPj4+IGIvZHJpdmVycy9ncHUv ZHJtL3JvY2tjaGlwL3JvY2tjaGlwX2RybV9kcnYuYwo+Pj4gaW5kZXggMDFiNTU4ZmUzNjk1Li45 YTBjMjkxMTI3MmEgMTAwNjQ0Cj4+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvcm9j a2NoaXBfZHJtX2Rydi5jCj4+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvcm9ja2No aXBfZHJtX2Rydi5jCj4+PiBAQCAtNTU1LDcgKzU1NSw2IEBAIHN0YXRpYyBzdHJ1Y3QgcGxhdGZv cm1fZHJpdmVyCj4+PiByb2NrY2hpcF9kcm1fcGxhdGZvcm1fZHJpdmVyID0gewo+Pj4gICAgICAg IC5wcm9iZSA9IHJvY2tjaGlwX2RybV9wbGF0Zm9ybV9wcm9iZSwKPj4+ICAgICAgICAucmVtb3Zl ID0gcm9ja2NoaXBfZHJtX3BsYXRmb3JtX3JlbW92ZSwKPj4+ICAgICAgICAuZHJpdmVyID0gewo+ Pj4gLSAgICAgICAgLm93bmVyID0gVEhJU19NT0RVTEUsCj4+IEJ1dCByb2NrY2hpcCBkcm0gaXMg cGxhdGZvcm0gZHJpdmVyIG5vdCBpMmNfZHJpdmVyLCB3aHkgcmVtb3ZlIGl0cyAub3duZXIgPwo+ IE9oLCBpbmRlZWQuIFRoYW5rcyBmb3Igc3BvdHRpbmcgdGhpcy4KPgo+IFRoZSAnb3duZXInIGlz IHNldCBieSBjb3JlIGZvciBwbGF0Zm9ybSBkcml2ZXJzIGFzIHdlbGwuIE1vc3QgcGxhdGZvcm0K PiBkcml2ZXJzIHdlcmUgYWxyZWFkeSBjb252ZXJ0ZWQgKEkgdGhpbmsgYnkgV29sZnJhbSBTYW5n KS4gSSBleHRlbmRlZAo+IGV4aXN0aW5nIGNvY2NpbmVsbGUgc2NyaXB0IHRvIGZpeCBhbHNvIGky Y19kcml2ZXJzIGFuZCBzb21ldGltZXMgZGlkIG5vdAo+IG5vdGljZSB0aGF0IGl0IHdhcyBwbGF0 Zm9ybV9kcml2ZXIuCj4KPiBJIGNhbiBzcGxpdCBpdCBpbnRvIHR3byBkaWZmZXJlbnQgcGF0Y2hl cy4gV291bGQgdGhhdCBiZSBvaz8KPgo+IEJlc3QgcmVnYXJkcywKPiBLcnp5c3p0b2YKPgpPaywg VGhhbmtzIGZvciB0aGUgZml4LjotKQoKLS0gCu+8rWFyawoKCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRl dmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: mark.yao@rock-chips.com (Mark yao) Date: Fri, 10 Jul 2015 15:11:35 +0800 Subject: [PATCH] drm: Drop owner assignment from i2c_driver In-Reply-To: <559F6DB6.9010000@samsung.com> References: <1436506597-1096-1-git-send-email-k.kozlowski@samsung.com> <1436506597-1096-2-git-send-email-k.kozlowski@samsung.com> <559F6B3C.8080908@rock-chips.com> <559F6DB6.9010000@samsung.com> Message-ID: <559F7027.6010602@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2015?07?10? 15:01, Krzysztof Kozlowski wrote: > On 10.07.2015 15:50, Mark yao wrote: >> On 2015?07?10? 13:36, Krzysztof Kozlowski wrote: >>> i2c_driver does not need to set an owner because i2c_register_driver() >>> will set it. >>> >>> Signed-off-by: Krzysztof Kozlowski >>> >>> --- >>> >>> The coccinelle script which generated the patch was sent here: >>> http://www.spinics.net/lists/kernel/msg2029903.html >>> --- >>> drivers/gpu/drm/bridge/ps8622.c | 1 - >>> drivers/gpu/drm/bridge/ptn3460.c | 1 - >>> drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 1 - >>> 3 files changed, 3 deletions(-) >>> >>> diff --git a/drivers/gpu/drm/bridge/ps8622.c >>> b/drivers/gpu/drm/bridge/ps8622.c >>> index 1a6607beb29f..be881e9fef8f 100644 >>> --- a/drivers/gpu/drm/bridge/ps8622.c >>> +++ b/drivers/gpu/drm/bridge/ps8622.c >>> @@ -668,7 +668,6 @@ static struct i2c_driver ps8622_driver = { >>> .remove = ps8622_remove, >>> .driver = { >>> .name = "ps8622", >>> - .owner = THIS_MODULE, >>> .of_match_table = ps8622_devices, >>> }, >>> }; >>> diff --git a/drivers/gpu/drm/bridge/ptn3460.c >>> b/drivers/gpu/drm/bridge/ptn3460.c >>> index 1b1bf2384815..0ffa3a6a206a 100644 >>> --- a/drivers/gpu/drm/bridge/ptn3460.c >>> +++ b/drivers/gpu/drm/bridge/ptn3460.c >>> @@ -400,7 +400,6 @@ static struct i2c_driver ptn3460_driver = { >>> .remove = ptn3460_remove, >>> .driver = { >>> .name = "nxp,ptn3460", >>> - .owner = THIS_MODULE, >>> .of_match_table = ptn3460_match, >>> }, >>> }; >>> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c >>> b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c >>> index 01b558fe3695..9a0c2911272a 100644 >>> --- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c >>> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c >>> @@ -555,7 +555,6 @@ static struct platform_driver >>> rockchip_drm_platform_driver = { >>> .probe = rockchip_drm_platform_probe, >>> .remove = rockchip_drm_platform_remove, >>> .driver = { >>> - .owner = THIS_MODULE, >> But rockchip drm is platform driver not i2c_driver, why remove its .owner ? > Oh, indeed. Thanks for spotting this. > > The 'owner' is set by core for platform drivers as well. Most platform > drivers were already converted (I think by Wolfram Sang). I extended > existing coccinelle script to fix also i2c_drivers and sometimes did not > notice that it was platform_driver. > > I can split it into two different patches. Would that be ok? > > Best regards, > Krzysztof > Ok, Thanks for the fix.:-) -- ?ark From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752953AbbGJHLr (ORCPT ); Fri, 10 Jul 2015 03:11:47 -0400 Received: from regular1.263xmail.com ([211.150.99.140]:34695 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752525AbbGJHLk (ORCPT ); Fri, 10 Jul 2015 03:11:40 -0400 X-263anti-spam: KSV:0;BIG:0;ABS:1;DNS:0;ATT:0;SPF:S; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ADDR-CHECKED: 0 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: k.kozlowski@samsung.com X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <559F7027.6010602@rock-chips.com> Date: Fri, 10 Jul 2015 15:11:35 +0800 From: Mark yao User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Krzysztof Kozlowski , David Airlie , Heiko Stuebner , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH] drm: Drop owner assignment from i2c_driver References: <1436506597-1096-1-git-send-email-k.kozlowski@samsung.com> <1436506597-1096-2-git-send-email-k.kozlowski@samsung.com> <559F6B3C.8080908@rock-chips.com> <559F6DB6.9010000@samsung.com> In-Reply-To: <559F6DB6.9010000@samsung.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015年07月10日 15:01, Krzysztof Kozlowski wrote: > On 10.07.2015 15:50, Mark yao wrote: >> On 2015年07月10日 13:36, Krzysztof Kozlowski wrote: >>> i2c_driver does not need to set an owner because i2c_register_driver() >>> will set it. >>> >>> Signed-off-by: Krzysztof Kozlowski >>> >>> --- >>> >>> The coccinelle script which generated the patch was sent here: >>> http://www.spinics.net/lists/kernel/msg2029903.html >>> --- >>> drivers/gpu/drm/bridge/ps8622.c | 1 - >>> drivers/gpu/drm/bridge/ptn3460.c | 1 - >>> drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 1 - >>> 3 files changed, 3 deletions(-) >>> >>> diff --git a/drivers/gpu/drm/bridge/ps8622.c >>> b/drivers/gpu/drm/bridge/ps8622.c >>> index 1a6607beb29f..be881e9fef8f 100644 >>> --- a/drivers/gpu/drm/bridge/ps8622.c >>> +++ b/drivers/gpu/drm/bridge/ps8622.c >>> @@ -668,7 +668,6 @@ static struct i2c_driver ps8622_driver = { >>> .remove = ps8622_remove, >>> .driver = { >>> .name = "ps8622", >>> - .owner = THIS_MODULE, >>> .of_match_table = ps8622_devices, >>> }, >>> }; >>> diff --git a/drivers/gpu/drm/bridge/ptn3460.c >>> b/drivers/gpu/drm/bridge/ptn3460.c >>> index 1b1bf2384815..0ffa3a6a206a 100644 >>> --- a/drivers/gpu/drm/bridge/ptn3460.c >>> +++ b/drivers/gpu/drm/bridge/ptn3460.c >>> @@ -400,7 +400,6 @@ static struct i2c_driver ptn3460_driver = { >>> .remove = ptn3460_remove, >>> .driver = { >>> .name = "nxp,ptn3460", >>> - .owner = THIS_MODULE, >>> .of_match_table = ptn3460_match, >>> }, >>> }; >>> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c >>> b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c >>> index 01b558fe3695..9a0c2911272a 100644 >>> --- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c >>> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c >>> @@ -555,7 +555,6 @@ static struct platform_driver >>> rockchip_drm_platform_driver = { >>> .probe = rockchip_drm_platform_probe, >>> .remove = rockchip_drm_platform_remove, >>> .driver = { >>> - .owner = THIS_MODULE, >> But rockchip drm is platform driver not i2c_driver, why remove its .owner ? > Oh, indeed. Thanks for spotting this. > > The 'owner' is set by core for platform drivers as well. Most platform > drivers were already converted (I think by Wolfram Sang). I extended > existing coccinelle script to fix also i2c_drivers and sometimes did not > notice that it was platform_driver. > > I can split it into two different patches. Would that be ok? > > Best regards, > Krzysztof > Ok, Thanks for the fix.:-) -- Ｍark