From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36141)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZDSze-0000gC-NX
	for qemu-devel@nongnu.org; Fri, 10 Jul 2015 03:45:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZDSza-0000vh-OH
	for qemu-devel@nongnu.org; Fri, 10 Jul 2015 03:45:10 -0400
Received: from mail-wi0-f177.google.com ([209.85.212.177]:35033)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZDSza-0000uP-Hl
	for qemu-devel@nongnu.org; Fri, 10 Jul 2015 03:45:06 -0400
Received: by wiga1 with SMTP id a1so7998998wig.0
	for <qemu-devel@nongnu.org>; Fri, 10 Jul 2015 00:44:21 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
References: <1436429849-18052-1-git-send-email-rth@twiddle.net>
	<1436429849-18052-6-git-send-email-rth@twiddle.net>
	<559E74BD.8050503@redhat.com>
From: Richard Henderson <rth@twiddle.net>
Message-ID: <559F77C8.9010701@twiddle.net>
Date: Fri, 10 Jul 2015 08:44:08 +0100
MIME-Version: 1.0
In-Reply-To: <559E74BD.8050503@redhat.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 05/14] target-i386: Enable control
	registers for MPX
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: ehabkost@redhat.com

On 07/09/2015 02:18 PM, Paolo Bonzini wrote:
>
>
> On 09/07/2015 10:17, Richard Henderson wrote:
>>
>> +void cpu_sync_bndcs_hf(CPUX86State *env)
>
> s/hf/hflags/ :)

Heh.  Done.

> Why aren't you just using a goto, like
>
>      if (ret < 0) {
>          goto out;
>      }
>      ret = 0;
> out:
>      cpu_sync_bndcs_hf(&cpu->env);
>      return ret;

Doh.  Done.  Thanks,


r~