All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Siluvery, Arun" <arun.siluvery@linux.intel.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: drm/i915: Update WaFlushCoherentL3CacheLinesAtContextSwitch
Date: Fri, 10 Jul 2015 12:56:14 +0100	[thread overview]
Message-ID: <559FB2DE.4040505@linux.intel.com> (raw)
In-Reply-To: <20150710082528.GB29999@mwanda>

On 10/07/2015 09:25, Dan Carpenter wrote:
> Hello Arun Siluvery,
>
> The patch 9e00084750c0: "drm/i915: Update
> WaFlushCoherentL3CacheLinesAtContextSwitch" from Jul 3, 2015, leads
> to the following static checker warning:
>
> 	drivers/gpu/drm/i915/intel_lrc.c:1188 gen8_init_indirectctx_bb()
> 	warn: unsigned 'index' is never less than zero.
>
> drivers/gpu/drm/i915/intel_lrc.c
>    1174  static int gen8_init_indirectctx_bb(struct intel_engine_cs *ring,
>    1175                                      struct i915_wa_ctx_bb *wa_ctx,
>    1176                                      uint32_t *const batch,
>    1177                                      uint32_t *offset)
>    1178  {
>    1179          uint32_t scratch_addr;
>    1180          uint32_t index = wa_ctx_start(wa_ctx, *offset, CACHELINE_DWORDS);
>    1181
>    1182          /* WaDisableCtxRestoreArbitration:bdw,chv */
>    1183          wa_ctx_emit(batch, index, MI_ARB_ON_OFF | MI_ARB_DISABLE);
>    1184
>    1185          /* WaFlushCoherentL3CacheLinesAtContextSwitch:bdw */
>    1186          if (IS_BROADWELL(ring->dev)) {
>    1187                  index = gen8_emit_flush_coherentl3_wa(ring, batch, index);
>    1188                  if (index < 0)
>                              ^^^^^^^^^
> Never true.

Thank you for reporting this, I will change it as below.

int ret = gen8_emit_flush_coherentl3_wa(ring, batch, index);
if (ret < 0)
         return ret;
index = ret;

regards
Arun

>
>    1189                          return index;
>    1190          }
>    1191
>
> regards,
> dan carpenter
>

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

      reply	other threads:[~2015-07-10 11:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-10  8:25 drm/i915: Update WaFlushCoherentL3CacheLinesAtContextSwitch Dan Carpenter
2015-07-10 11:56 ` Siluvery, Arun [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=559FB2DE.4040505@linux.intel.com \
    --to=arun.siluvery@linux.intel.com \
    --cc=dan.carpenter@oracle.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.