All of lore.kernel.org
 help / color / mirror / Atom feed
From: vaibhav.hiremath@linaro.org (Vaibhav Hiremath)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] regulator: 88pm800: Add dev_info to show probe success status
Date: Fri, 10 Jul 2015 17:42:17 +0530	[thread overview]
Message-ID: <559FB6A1.7060903@linaro.org> (raw)
In-Reply-To: <13146.1436470614@turing-police.cc.vt.edu>



On Friday 10 July 2015 01:06 AM, Valdis.Kletnieks at vt.edu wrote:
> On Thu, 09 Jul 2015 18:11:32 +0530, Vaibhav Hiremath said:
>> This patch adds dev_info line at the end of probe function, to
>> clearly put status of regulator probe on console. Useful during
>> development, specially to check bootlog.
>
> I can see that as a development thing...
>
>> +	dev_info(&pdev->dev, "Regulator registered ...\n");
>
> In which case this should be 'dev_debug()' or similar so it doesn't
> clutter up and slow down a production boot.
>

Yeup,

Probably dev_debug would have been better here.

Thanks,
Vaibhav

WARNING: multiple messages have this Message-ID (diff)
From: Vaibhav Hiremath <vaibhav.hiremath@linaro.org>
To: Valdis.Kletnieks@vt.edu
Cc: linux-arm-kernel@lists.infradead.org, lgirdwood@gmail.com,
	broonie@kernel.org, sameo@linux.intel.com, lee.jones@linaro.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] regulator: 88pm800: Add dev_info to show probe success status
Date: Fri, 10 Jul 2015 17:42:17 +0530	[thread overview]
Message-ID: <559FB6A1.7060903@linaro.org> (raw)
In-Reply-To: <13146.1436470614@turing-police.cc.vt.edu>



On Friday 10 July 2015 01:06 AM, Valdis.Kletnieks@vt.edu wrote:
> On Thu, 09 Jul 2015 18:11:32 +0530, Vaibhav Hiremath said:
>> This patch adds dev_info line at the end of probe function, to
>> clearly put status of regulator probe on console. Useful during
>> development, specially to check bootlog.
>
> I can see that as a development thing...
>
>> +	dev_info(&pdev->dev, "Regulator registered ...\n");
>
> In which case this should be 'dev_debug()' or similar so it doesn't
> clutter up and slow down a production boot.
>

Yeup,

Probably dev_debug would have been better here.

Thanks,
Vaibhav

  parent reply	other threads:[~2015-07-10 12:12 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-09 12:41 [PATCH 0/3] regulator: 88pm800: Add 88pm860 regulator support Vaibhav Hiremath
2015-07-09 12:41 ` Vaibhav Hiremath
2015-07-09 12:41 ` [PATCH 1/3] " Vaibhav Hiremath
2015-07-09 12:41   ` Vaibhav Hiremath
2015-07-09 13:59   ` Lee Jones
2015-07-09 13:59     ` Lee Jones
2015-07-09 18:35   ` Mark Brown
2015-07-09 18:35     ` Mark Brown
2015-07-09 12:41 ` [PATCH 2/3] regulator: 88pm800: fix LDO vsel_mask value Vaibhav Hiremath
2015-07-09 12:41   ` Vaibhav Hiremath
2015-07-09 19:04   ` Mark Brown
2015-07-09 19:04     ` Mark Brown
2015-07-10 12:07     ` Vaibhav Hiremath
2015-07-10 12:07       ` Vaibhav Hiremath
2015-07-10  0:25   ` Applied "regulator: 88pm800: fix LDO vsel_mask value" to the regulator tree Mark Brown
2015-07-09 12:41 ` [PATCH 3/3] regulator: 88pm800: Add dev_info to show probe success status Vaibhav Hiremath
2015-07-09 12:41   ` Vaibhav Hiremath
2015-07-09 19:05   ` Mark Brown
2015-07-09 19:05     ` Mark Brown
2015-07-10 12:11     ` Vaibhav Hiremath
2015-07-10 12:11       ` Vaibhav Hiremath
2015-07-09 19:36   ` Valdis.Kletnieks at vt.edu
2015-07-09 19:36     ` Valdis.Kletnieks
2015-07-09 22:05     ` Mark Brown
2015-07-09 22:05       ` Mark Brown
2015-07-10 12:12     ` Vaibhav Hiremath [this message]
2015-07-10 12:12       ` Vaibhav Hiremath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=559FB6A1.7060903@linaro.org \
    --to=vaibhav.hiremath@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.