From: Vignesh R <vigneshr@ti.com>
To: Alexander Sverdlin <alexander.sverdlin@nokia.com>,
Wolfram Sang <wsa@the-dreams.de>, Felipe Balbi <balbi@ti.com>
Cc: Tony Lindgren <tony@atomide.com>,
linux-omap@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] i2c: busses: i2c-omap: Increase timeout for i2c interrupt
Date: Fri, 10 Jul 2015 19:14:23 +0530 [thread overview]
Message-ID: <559FCC37.10201@ti.com> (raw)
In-Reply-To: <559FC7E9.1060003@nokia.com>
Hi,
On 07/10/2015 06:56 PM, Alexander Sverdlin wrote:
> Hi!
>
> On 10/07/15 15:17, ext Vignesh R wrote:
>>>> I would propose you to throw away spinlocks. Convert threaded IRQ to
>>>>>> just one hardirq handler. And continue debugging. You will reduce the
>>>>>> load of the system with the above measures, maybe it will not happen
>>>>>> any more, maybe you'll figure out that problem is somewhere else.
>>>>
>>>> Or this.
>> I am not convinced with moving entire code at hardirq context. I believe
>> its better to keep hardirq as small as possible.
>
> How deep is the controller's FIFO? 1 byte? 2 bytes?
As per AM57x TRM[1] section 24.1.4.8 max FIFO depth can be 64bytes.
[1] http://www.ti.com/lit/ug/spruhz6/spruhz6.pdf
--
Regards
Vignesh
WARNING: multiple messages have this Message-ID (diff)
From: Vignesh R <vigneshr@ti.com>
To: Alexander Sverdlin <alexander.sverdlin@nokia.com>,
Wolfram Sang <wsa@the-dreams.de>, Felipe Balbi <balbi@ti.com>
Cc: Tony Lindgren <tony@atomide.com>, <linux-omap@vger.kernel.org>,
<linux-i2c@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH] i2c: busses: i2c-omap: Increase timeout for i2c interrupt
Date: Fri, 10 Jul 2015 19:14:23 +0530 [thread overview]
Message-ID: <559FCC37.10201@ti.com> (raw)
In-Reply-To: <559FC7E9.1060003@nokia.com>
Hi,
On 07/10/2015 06:56 PM, Alexander Sverdlin wrote:
> Hi!
>
> On 10/07/15 15:17, ext Vignesh R wrote:
>>>> I would propose you to throw away spinlocks. Convert threaded IRQ to
>>>>>> just one hardirq handler. And continue debugging. You will reduce the
>>>>>> load of the system with the above measures, maybe it will not happen
>>>>>> any more, maybe you'll figure out that problem is somewhere else.
>>>>
>>>> Or this.
>> I am not convinced with moving entire code at hardirq context. I believe
>> its better to keep hardirq as small as possible.
>
> How deep is the controller's FIFO? 1 byte? 2 bytes?
As per AM57x TRM[1] section 24.1.4.8 max FIFO depth can be 64bytes.
[1] http://www.ti.com/lit/ug/spruhz6/spruhz6.pdf
--
Regards
Vignesh
next prev parent reply other threads:[~2015-07-10 13:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-10 5:09 [RFC PATCH] i2c: busses: i2c-omap: Increase timeout for i2c interrupt Vignesh R
2015-07-10 5:09 ` Vignesh R
[not found] ` <1436504994-31137-1-git-send-email-vigneshr-l0cyMroinI0@public.gmane.org>
2015-07-10 8:09 ` Roger Quadros
2015-07-10 8:09 ` Roger Quadros
2015-07-10 8:46 ` Alexander Sverdlin
2015-07-10 9:09 ` Wolfram Sang
2015-07-10 13:17 ` Vignesh R
2015-07-10 13:17 ` Vignesh R
[not found] ` <559FC5D7.3000108-l0cyMroinI0@public.gmane.org>
2015-07-10 13:26 ` Alexander Sverdlin
2015-07-10 13:26 ` Alexander Sverdlin
2015-07-10 13:44 ` Vignesh R [this message]
2015-07-10 13:44 ` Vignesh R
[not found] ` <559FC7E9.1060003-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2015-07-10 13:48 ` Grygorii Strashko
2015-07-10 13:48 ` Grygorii Strashko
2015-07-10 14:02 ` Grygorii Strashko
2015-07-10 14:02 ` Grygorii Strashko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559FCC37.10201@ti.com \
--to=vigneshr@ti.com \
--cc=alexander.sverdlin@nokia.com \
--cc=balbi@ti.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.