From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932524AbbGJO2e (ORCPT ); Fri, 10 Jul 2015 10:28:34 -0400 Received: from mail-ig0-f180.google.com ([209.85.213.180]:38576 "EHLO mail-ig0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754587AbbGJO2Y (ORCPT ); Fri, 10 Jul 2015 10:28:24 -0400 Message-ID: <559FD686.2000306@kernel.dk> Date: Fri, 10 Jul 2015 08:28:22 -0600 From: Jens Axboe User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Tejun Heo CC: vgoyal@redhat.com, linux-kernel@vger.kernel.org, avanzini.arianna@gmail.com, kernel-team@fb.com Subject: Re: [PATCHSET block/for-linus] blkcg: blkcg_policy_data fixes References: <1436474390-3762-1-git-send-email-tj@kernel.org> In-Reply-To: <1436474390-3762-1-git-send-email-tj@kernel.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/09/2015 02:39 PM, Tejun Heo wrote: > During 4.2-rc1 merge window, e48453c386f3 ("block, cgroup: implement > policy-specific per-blkcg data") got merged. It had several bugs and > a322baad1003 ("block/blk-cgroup.c: free per-blkcg data when freeing > the blkcg") fixed one of them but there are still a couple remaining. > > * blkcg_policy[] iteration during css_alloc isn't protected. > > * Lazy allocation scheme is broken and policy data may be missing or > an old policy data may get reused by the wrong policy. > > This patchset contains the following four patches to fix the above > issues. > > 0001-blkcg-allow-blkcg_pol_mutex-to-be-grabbed-from-cgrou.patch > 0002-blkcg-blkcg_css_alloc-should-grab-blkcg_pol_mutex-wh.patch > 0003-blkcg-implement-all_blkcgs-list.patch > 0004-blkcg-fix-blkcg_policy_data-allocation-bug.patch > > 0001 and 0003 are prep patches. 0002 and 0004 are the fixes. > > This patchset is on top of block/for-linus a322baad1003 > ("block/blk-cgroup.c: free per-blkcg data when freeing the blkcg") and > available in the following git branch. > > git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git review-blkcg-cpd-fixes > > diffstat follows, thanks. Applied, thanks Tejun. -- Jens Axboe