From: "Suzuki K. Poulose" <Suzuki.Poulose@arm.com>
To: Mark Brown <broonie@kernel.org>
Cc: "sfr@canb.auug.org.au" <sfr@canb.auug.org.au>,
"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"paul@pwsan.com" <paul@pwsan.com>,
"treding@nvidia.com" <treding@nvidia.com>,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH] regulators: Add missing dummy definition for regulator_list_voltage
Date: Fri, 10 Jul 2015 16:14:25 +0100 [thread overview]
Message-ID: <559FE151.2030305@arm.com> (raw)
In-Reply-To: <20150707123838.GF2887@sirena.org.uk>
On 07/07/15 13:38, Mark Brown wrote:
> On Fri, Jun 26, 2015 at 12:06:50PM +0100, Suzuki K. Poulose wrote:
>
>> +static inline int regulator_list_voltage(struct regulator *regulator, unsigned selector)
>> +{
>> + return 0;
>> +}
>
> I'd expect this stub to return -EINVAL since the voltage count should be
> zero for !REGULATOR (since we obviously can't count the number of
> voltages).
>
You are right, -EINVAL suites better. There are some users of the
API who consider 0 as invalid, but -EINVAL sounds better and covers
all the existing uses. Will resend the patch.
Thanks
Suzuki
prev parent reply other threads:[~2015-07-10 15:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-26 9:08 linux-next: Tree for Jun 26 Stephen Rothwell
2015-06-26 10:55 ` Suzuki K. Poulose
2015-06-26 11:06 ` [PATCH] regulators: Add missing dummy definition for regulator_list_voltage Suzuki K. Poulose
2015-07-07 12:38 ` Mark Brown
2015-07-10 15:14 ` Suzuki K. Poulose [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559FE151.2030305@arm.com \
--to=suzuki.poulose@arm.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=sfr@canb.auug.org.au \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.