From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Ferre Subject: Re: [PATCH 1/2] power: reset: at91: add sama5d3 reset function Date: Fri, 10 Jul 2015 18:12:03 +0200 Message-ID: <559FEED3.5080505@atmel.com> References: <1436436947-11210-1-git-send-email-josh.wu@atmel.com> <20150710060350.GA3127@piout.net> <559F7AC4.6050008@atmel.com> <20150710120907.GC3127@piout.net> <20150710123148.GA28632@lukather> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from eusmtp01.atmel.com ([212.144.249.243]:35547 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932124AbbGJQNR (ORCPT ); Fri, 10 Jul 2015 12:13:17 -0400 In-Reply-To: <20150710123148.GA28632@lukather> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Maxime Ripard , Alexandre Belloni , Josh Wu Cc: linux-arm-kernel@lists.infradead.org, Guenter Roeck , Wei Yongjun , Ben Dooks , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , Fabian Frederick , linux-pm@vger.kernel.org Le 10/07/2015 14:31, Maxime Ripard a =E9crit : > On Fri, Jul 10, 2015 at 02:09:07PM +0200, Alexandre Belloni wrote: >> Hi, >> >> On 10/07/2015 at 15:56:52 +0800, Josh Wu wrote : >>> I would agree with Maxime. Currently all latest chip reset function= is >>> compatible with the atmel,sama5d3-rstc. >>> So check compatible string is enough for now. >>> But of cause if we have other incompatible reset in future with new= chip, >>> the structure like you said is needed. >> >> We managed to avoid using of_machine_is_compatible() in all the at91 >> drivers. I'd like to keep it that way. It was painful enough to remo= ve >> all those cpu_is_at91xxx calls. >=20 > That's your call... >=20 >> Also, using it is trying to match strings and will result in longer = boot >> times. >=20 > Have you looked at the implementation of of_match_device? If that's > really a concern to you, you should actually avoid it. I agree: let's keep it simple and use of_match_device(). Bye, --=20 Nicolas Ferre From mboxrd@z Thu Jan 1 00:00:00 1970 From: nicolas.ferre@atmel.com (Nicolas Ferre) Date: Fri, 10 Jul 2015 18:12:03 +0200 Subject: [PATCH 1/2] power: reset: at91: add sama5d3 reset function In-Reply-To: <20150710123148.GA28632@lukather> References: <1436436947-11210-1-git-send-email-josh.wu@atmel.com> <20150710060350.GA3127@piout.net> <559F7AC4.6050008@atmel.com> <20150710120907.GC3127@piout.net> <20150710123148.GA28632@lukather> Message-ID: <559FEED3.5080505@atmel.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Le 10/07/2015 14:31, Maxime Ripard a ?crit : > On Fri, Jul 10, 2015 at 02:09:07PM +0200, Alexandre Belloni wrote: >> Hi, >> >> On 10/07/2015 at 15:56:52 +0800, Josh Wu wrote : >>> I would agree with Maxime. Currently all latest chip reset function is >>> compatible with the atmel,sama5d3-rstc. >>> So check compatible string is enough for now. >>> But of cause if we have other incompatible reset in future with new chip, >>> the structure like you said is needed. >> >> We managed to avoid using of_machine_is_compatible() in all the at91 >> drivers. I'd like to keep it that way. It was painful enough to remove >> all those cpu_is_at91xxx calls. > > That's your call... > >> Also, using it is trying to match strings and will result in longer boot >> times. > > Have you looked at the implementation of of_match_device? If that's > really a concern to you, you should actually avoid it. I agree: let's keep it simple and use of_match_device(). Bye, -- Nicolas Ferre From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932376AbbGJQN0 (ORCPT ); Fri, 10 Jul 2015 12:13:26 -0400 Received: from eusmtp01.atmel.com ([212.144.249.243]:35547 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932124AbbGJQNR (ORCPT ); Fri, 10 Jul 2015 12:13:17 -0400 Message-ID: <559FEED3.5080505@atmel.com> Date: Fri, 10 Jul 2015 18:12:03 +0200 From: Nicolas Ferre Organization: atmel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Maxime Ripard , Alexandre Belloni , Josh Wu CC: , Guenter Roeck , Wei Yongjun , Ben Dooks , , "Krzysztof Kozlowski" , Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , Fabian Frederick , Subject: Re: [PATCH 1/2] power: reset: at91: add sama5d3 reset function References: <1436436947-11210-1-git-send-email-josh.wu@atmel.com> <20150710060350.GA3127@piout.net> <559F7AC4.6050008@atmel.com> <20150710120907.GC3127@piout.net> <20150710123148.GA28632@lukather> In-Reply-To: <20150710123148.GA28632@lukather> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.161.30.18] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 10/07/2015 14:31, Maxime Ripard a écrit : > On Fri, Jul 10, 2015 at 02:09:07PM +0200, Alexandre Belloni wrote: >> Hi, >> >> On 10/07/2015 at 15:56:52 +0800, Josh Wu wrote : >>> I would agree with Maxime. Currently all latest chip reset function is >>> compatible with the atmel,sama5d3-rstc. >>> So check compatible string is enough for now. >>> But of cause if we have other incompatible reset in future with new chip, >>> the structure like you said is needed. >> >> We managed to avoid using of_machine_is_compatible() in all the at91 >> drivers. I'd like to keep it that way. It was painful enough to remove >> all those cpu_is_at91xxx calls. > > That's your call... > >> Also, using it is trying to match strings and will result in longer boot >> times. > > Have you looked at the implementation of of_match_device? If that's > really a concern to you, you should actually avoid it. I agree: let's keep it simple and use of_match_device(). Bye, -- Nicolas Ferre