From mboxrd@z Thu Jan  1 00:00:00 1970
From: Razvan Cojocaru <rcojocaru@bitdefender.com>
Subject: Re: [PATCH v4 15/15] tools/xen-access: altp2m testcases
Date: Sat, 11 Jul 2015 09:06:22 +0300
Message-ID: <55A0B25E.5090602@bitdefender.com>
References: <1436489553-6300-1-git-send-email-edmund.h.white@intel.com>
	<1436489553-6300-16-git-send-email-edmund.h.white@intel.com>
	<CAD33N+5YQWuNNdhNYh-SnjorP78sqrfsOrLOTCDs64ruAH8Ddg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <CAD33N+5YQWuNNdhNYh-SnjorP78sqrfsOrLOTCDs64ruAH8Ddg@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: "Lengyel, Tamas" <tlengyel@novetta.com>, Ed White <edmund.h.white@intel.com>
Cc: Ravi Sahita <ravi.sahita@intel.com>, Wei Liu <wei.liu2@citrix.com>, George Dunlap <george.dunlap@eu.citrix.com>, Tim Deegan <tim@xen.org>, Ian Jackson <ian.jackson@eu.citrix.com>, Xen-devel <xen-devel@lists.xen.org>, Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Daniel De Graaf <dgdegra@tycho.nsa.gov>
List-Id: xen-devel@lists.xenproject.org

On 07/10/2015 04:35 AM, Lengyel, Tamas wrote:
> 
>     @@ -546,6 +652,23 @@ int main(int argc, char *argv[])
>                      }
> 
>                      break;
>     +            case VM_EVENT_REASON_SINGLESTEP:
>     +                printf("Singlestep: rip=%016"PRIx64", vcpu %d\n",
>     +                       req.regs.x86.rip,
>     +                       req.vcpu_id);
>     +
>     +                if ( altp2m )
>     +                {
>     +                    printf("\tSwitching altp2m to view %u!\n",
>     altp2m_view_id);
>     +
>     +                    rsp.reason = VM_EVENT_REASON_MEM_ACCESS;
> 
> 
> So this was a workaround for v3 of the series that is no longer
> necessary - it's probably cleaner to have the same reason set for the
> response as the request was. It's not against any rule, so the code is
> still correct and works, it's just not best practice. So in case there
> is another round on the series, it could be fixed then.

With or without that change (but preferably with it):

Reviewed-by: Razvan Cojocaru <rcojocaru@bitdefender.com>