From: Jonathan Cameron <jic23@kernel.org>
To: Cristina Opriceana <cristina.opriceana@gmail.com>
Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
daniel.baluta@intel.com
Subject: Re: [PATCH] Staging: iio: dummy: Fix blank line warnings
Date: Sat, 11 Jul 2015 18:42:31 +0100 [thread overview]
Message-ID: <55A15587.9060408@kernel.org> (raw)
In-Reply-To: <20150710141021.GA7015@Inspiron>
On 10/07/15 15:10, Cristina Opriceana wrote:
> Multiple blank lines should not be used as indicated by checkpatch.pl.
> Also, a line should be used after a function/structure declaration.
>
> Signed-off-by: Cristina Opriceana <cristina.opriceana@gmail.com>
Applied to the togreg branch of iio.git
Thanks,
Jonathan
> ---
> drivers/staging/iio/iio_dummy_evgen.c | 1 +
> drivers/staging/iio/iio_simple_dummy.c | 2 --
> drivers/staging/iio/iio_simple_dummy.h | 1 +
> drivers/staging/iio/iio_simple_dummy_buffer.c | 2 +-
> 4 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/iio/iio_dummy_evgen.c b/drivers/staging/iio/iio_dummy_evgen.c
> index c54d5b5..6d38854 100644
> --- a/drivers/staging/iio/iio_dummy_evgen.c
> +++ b/drivers/staging/iio/iio_dummy_evgen.c
> @@ -214,6 +214,7 @@ static struct device iio_evgen_dev = {
> .groups = iio_evgen_groups,
> .release = &iio_evgen_release,
> };
> +
> static __init int iio_dummy_evgen_init(void)
> {
> int ret = iio_dummy_evgen_create();
> diff --git a/drivers/staging/iio/iio_simple_dummy.c b/drivers/staging/iio/iio_simple_dummy.c
> index 1629a8a..381f90f 100644
> --- a/drivers/staging/iio/iio_simple_dummy.c
> +++ b/drivers/staging/iio/iio_simple_dummy.c
> @@ -611,7 +611,6 @@ static int iio_dummy_probe(int index)
> */
> iio_dummy_devs[index] = indio_dev;
>
> -
> /*
> * Set the device name.
> *
> @@ -675,7 +674,6 @@ static void iio_dummy_remove(int index)
> */
> struct iio_dev *indio_dev = iio_dummy_devs[index];
>
> -
> /* Unregister the device */
> iio_device_unregister(indio_dev);
>
> diff --git a/drivers/staging/iio/iio_simple_dummy.h b/drivers/staging/iio/iio_simple_dummy.h
> index e877a99..8d00224 100644
> --- a/drivers/staging/iio/iio_simple_dummy.h
> +++ b/drivers/staging/iio/iio_simple_dummy.h
> @@ -119,6 +119,7 @@ static inline int iio_simple_dummy_configure_buffer(struct iio_dev *indio_dev)
> {
> return 0;
> };
> +
> static inline
> void iio_simple_dummy_unconfigure_buffer(struct iio_dev *indio_dev)
> {};
> diff --git a/drivers/staging/iio/iio_simple_dummy_buffer.c b/drivers/staging/iio/iio_simple_dummy_buffer.c
> index a651b89..00ed774 100644
> --- a/drivers/staging/iio/iio_simple_dummy_buffer.c
> +++ b/drivers/staging/iio/iio_simple_dummy_buffer.c
> @@ -32,6 +32,7 @@ static const s16 fakedata[] = {
> [diffvoltage3m4] = -2,
> [accelx] = 344,
> };
> +
> /**
> * iio_simple_dummy_trigger_h() - the trigger handler function
> * @irq: the interrupt number
> @@ -178,7 +179,6 @@ error_free_buffer:
> iio_kfifo_free(indio_dev->buffer);
> error_ret:
> return ret;
> -
> }
>
> /**
>
prev parent reply other threads:[~2015-07-11 17:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-10 14:10 [PATCH] Staging: iio: dummy: Fix blank line warnings Cristina Opriceana
2015-07-11 17:42 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A15587.9060408@kernel.org \
--to=jic23@kernel.org \
--cc=cristina.opriceana@gmail.com \
--cc=daniel.baluta@intel.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.