All of lore.kernel.org
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: LKML <linux-kernel@vger.kernel.org>,
	Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
	Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>
Subject: V4.1-RC build error after commit 77a3c6f
Date: Sat, 11 Jul 2015 16:27:36 -0500	[thread overview]
Message-ID: <55A18A48.7030007@lwfinger.net> (raw)

[-- Attachment #1: Type: text/plain, Size: 1594 bytes --]

Beginning with the commit in the subject, I get the following build error:

   CC [M]  drivers/media/v4l2-core/videobuf2-core.o
drivers/media/v4l2-core/videobuf2-core.c: In function ‘vb2_warn_zero_bytesused’:
drivers/media/v4l2-core/videobuf2-core.c:1253:2: error: implicit declaration of 
function ‘__WARN’ [-Werror=implicit-function-declaration]
   __WARN();
   ^
cc1: some warnings being treated as errors

My .config is attached.

This problem has been bisected to the following commit:

commit 77a3c6fd90c94f635edb00d4a65f485687538791
Author: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Date:   Fri Jun 19 08:50:07 2015 -0300

     [media] vb2: Don't WARN when v4l2_buffer.bytesused is 0 for multiplanar buffers

     Commit f61bf13b6a07 ("[media] vb2: add allow_zero_bytesused flag to the
     vb2_queue struct") added a WARN_ONCE to catch usage of a deprecated API
     using a zero value for v4l2_buffer.bytesused.

     However, the condition is checked incorrectly, as the v4L2_buffer
     bytesused field is supposed to be ignored for multiplanar buffers. This
     results in spurious warnings when using the multiplanar API.

     Fix it by checking v4l2_buffer.bytesused for uniplanar buffers and
     v4l2_plane.bytesused for multiplanar buffers.

     Fixes: f61bf13b6a07 ("[media] vb2: add allow_zero_bytesused flag to the 
vb2_queue struct")

     Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
     Cc: stable@vger.kernel.org # for v4.0
     Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>

Thanks,

Larry

[-- Attachment #2: .config --]
[-- Type: application/x-config, Size: 110253 bytes --]

             reply	other threads:[~2015-07-11 21:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-11 21:27 Larry Finger [this message]
2015-07-11 21:30 ` V4.1-RC build error after commit 77a3c6f Larry Finger
2015-07-12 23:10 ` Laurent Pinchart
2015-07-13  1:35   ` Larry Finger
2015-07-13  8:25     ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55A18A48.7030007@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@osg.samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.