From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41833)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1ZE3BG-0005NE-Hl
	for qemu-devel@nongnu.org; Sat, 11 Jul 2015 18:23:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1ZE3BB-0006sr-Hl
	for qemu-devel@nongnu.org; Sat, 11 Jul 2015 18:23:34 -0400
Received: from mail-wg0-x235.google.com ([2a00:1450:400c:c00::235]:33695)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1ZE3BB-0006sj-AD
	for qemu-devel@nongnu.org; Sat, 11 Jul 2015 18:23:29 -0400
Received: by wgmn9 with SMTP id n9so18758514wgm.0
	for <qemu-devel@nongnu.org>; Sat, 11 Jul 2015 15:23:28 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
References: <CAEgOgz7FbShvfsz3E_QPmj-Xv8tWbkmimWO+65xrQoQH7wp7sA@mail.gmail.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <55A1975B.5000500@redhat.com>
Date: Sun, 12 Jul 2015 00:23:23 +0200
MIME-Version: 1.0
In-Reply-To: <CAEgOgz7FbShvfsz3E_QPmj-Xv8tWbkmimWO+65xrQoQH7wp7sA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] Semantics of tcg_enabled() and what it means for
	multi-arch
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>, Richard Henderson <rth@twiddle.net>, "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>



On 11/07/2015 22:46, Peter Crosthwaite wrote:
> include/exec/ram_addr.h:                if (tcg_enabled()) {
> include/exec/ram_addr.h:        uint8_t clients = tcg_enabled() ?
> DIRTY_CLIENTS_ALL : DIRTY_CLIENTS_NOCODE;
> memory.c:    mr->dirty_log_mask = tcg_enabled() ? (1 << DIRTY_MEMORY_CODE) : 0;
> memory.c:    mr->dirty_log_mask = tcg_enabled() ? (1 << DIRTY_MEMORY_CODE) : 0;
> memory.c:    mr->dirty_log_mask = tcg_enabled() ? (1 << DIRTY_MEMORY_CODE) : 0;
> memory.c:    mr->dirty_log_mask = tcg_enabled() ? (1 << DIRTY_MEMORY_CODE) : 0;
> 
> So what is the correct logic for populating dirty_log_mask and friends
> when there are 0. 1, or more TCG engines?

I think it should be set if there's at least one TCG engine.

Have you checked BTW it the DIRTY_MEMORY_CODE stuff works with multiple
tcg_ctxs _and_ the same page hosts code for more than one CPU type?
Offhand I have no idea of the answer...

Paolo