Re: [Qemu-devel] [PATCH 3/8] disas: m68k: QOMify target specific disas setup

[Laurent Vivier <laurent@vivier.eu>]

Le 12/07/2015 04:00, Peter Crosthwaite a écrit :
> From: Peter Crosthwaite <crosthwaitepeter@gmail.com>
> 
> Move the target_disas() m68k specifics to the QOM disas_set_info hook
> and delete the #ifdef specific code in disas.c.
> 
> Cc: Greg Ungerer <gerg@uclinux.org>
> Cc: Laurent Vivier <laurent@vivier.eu>
> Signed-off-by: Peter Crosthwaite <crosthwaite.peter@gmail.com>
> ---
> Testing:
> I cant find binaries for this arch easily, but I got this from executing
> random code:
> 
> $ ./m68k-softmmu/qemu-system-m68k -kernel ./random_code -S -nographic -d in_asm 2> err
> QEMU 2.3.90 monitor - type 'help' for more information
> (qemu) xp 0x40000000
> 0000000040000000: 0x7d413a22
> (qemu) xp/i 0x40000000
> 0x40000000:  mvsw %d1,%d6
> (qemu) xp/i 0x40000004
> 0x40000004:  addqb #2,%a0@(27614)
> (qemu) c
> (qemu) Aborted (core dumped)
> 
> $ more err
> qemu: fatal: Illegal instruction: 7d41 @ 40000000
> ---
>  disas.c           | 4 ----
>  target-m68k/cpu.c | 7 +++++++
>  2 files changed, 7 insertions(+), 4 deletions(-)

Reviewed-by: Laurent Vivier <laurent@vivier.eu>