All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/7] package/linux: don't enforce check for DTS when not building
Date: Mon, 13 Jul 2015 01:44:31 +0200	[thread overview]
Message-ID: <55A2FBDF.9070808@mind.be> (raw)
In-Reply-To: <20150712200309.GB2451@tarshish>

On 07/12/15 22:03, Baruch Siach wrote:
> Hi Yann,
> 
> On Sun, Jul 12, 2015 at 02:11:24PM +0200, Yann E. MORIN wrote:
>> Currently, this is triggering the error message:
>>     make randconfig
>>     make source
>>
>> Limit the checks that enforce a DTS is set and at most one DTB is
>> appended to when we are actually building, like is done for the
>> configuration-file variables.
>>
>> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> 
> [snip]
> 
>> -ifeq ($(BR2_LINUX_KERNEL_DTS_SUPPORT)$(KERNEL_DTS_NAME),y)
>> +ifeq ($(BR_BUILDING)$(BR2_LINUX_KERNEL_DTS_SUPPORT)$(KERNEL_DTS_NAME),yy)
> 
> yy means that exactly two of these must be 'y'. Is that intended?

 Yes it is, because KERNEL_DTS_NAME is a string, not a boolean, so it
essentially checks that it is empty and DTS_SUPPORT is selected. But admittedly
it's not very transparent, it would make sense to add delimiters in-between at
least.

 Regards,
 Arnout


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

  reply	other threads:[~2015-07-12 23:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-12 12:11 [Buildroot] [PATCH 0/7] core/kconfig: fix display of custom error messages (branch yem/misc) Yann E. MORIN
2015-07-12 12:11 ` [Buildroot] [PATCH 1/7] core/pkg-kconfig: don't enforce check for config file when not building Yann E. MORIN
2015-07-12 12:11 ` [Buildroot] [PATCH 2/7] package/linux: don't enforce check for DTS " Yann E. MORIN
2015-07-12 20:03   ` Baruch Siach
2015-07-12 23:44     ` Arnout Vandecappelle [this message]
2015-07-13  3:37       ` Baruch Siach
2015-07-13  7:18         ` Yann E. MORIN
2015-07-12 12:11 ` [Buildroot] [PATCH 3/7] boot/at91boostrap3: check for config file before calling kconfig-package Yann E. MORIN
2015-07-12 12:11 ` [Buildroot] [PATCH 4/7] boot/barebox: " Yann E. MORIN
2015-07-12 12:11 ` [Buildroot] [PATCH 5/7] package/linux: " Yann E. MORIN
2015-07-12 12:11 ` [Buildroot] [PATCH 6/7] package/busybox: " Yann E. MORIN
2015-07-12 12:11 ` [Buildroot] [PATCH 7/7] package/uclibc: " Yann E. MORIN
2015-07-12 20:06   ` Baruch Siach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55A2FBDF.9070808@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.