From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark yao Subject: Re: [PATCH v2 2/2] drm/rockchip: Drop owner assignment from platform_driver Date: Mon, 13 Jul 2015 14:03:02 +0800 Message-ID: <55A35496.5060206@rock-chips.com> References: <1436524653-29132-1-git-send-email-k.kozlowski@samsung.com> <1436524653-29132-3-git-send-email-k.kozlowski@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1436524653-29132-3-git-send-email-k.kozlowski@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Krzysztof Kozlowski , David Airlie , Heiko Stuebner , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org T24gMjAxNeW5tDA35pyIMTDml6UgMTg6MzcsIEtyenlzenRvZiBLb3psb3dza2kgd3JvdGU6Cj4g cGxhdGZvcm1fZHJpdmVyIGRvZXMgbm90IG5lZWQgdG8gc2V0IGFuIG93bmVyIGJlY2F1c2UKPiBw bGF0Zm9ybV9kcml2ZXJfcmVnaXN0ZXIoKSB3aWxsIHNldCBpdC4KPgo+IFNpZ25lZC1vZmYtYnk6 IEtyenlzenRvZiBLb3psb3dza2kgPGsua296bG93c2tpQHNhbXN1bmcuY29tPgo+Cj4gLS0tCj4g Q2hhbmdlcyBzaW5jZSB2MToKPiAxLiBTcGxpdCBvd25lciByZW1vdmFsIGZyb20gcm9ja2NoaXAg dG8gc2VwYXJhdGUgcGF0Y2ggKHNwb3R0ZWQgYnkgTWFyawo+ICAgICBZYW8pLgo+IC0tLQo+ICAg ZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL3JvY2tjaGlwX2RybV9kcnYuYyB8IDEgLQo+ICAgMSBm aWxlIGNoYW5nZWQsIDEgZGVsZXRpb24oLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vcm9ja2NoaXAvcm9ja2NoaXBfZHJtX2Rydi5jIGIvZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlw L3JvY2tjaGlwX2RybV9kcnYuYwo+IGluZGV4IDAxYjU1OGZlMzY5NS4uOWEwYzI5MTEyNzJhIDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9yb2NrY2hpcF9kcm1fZHJ2LmMK PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvcm9ja2NoaXBfZHJtX2Rydi5jCj4gQEAg LTU1NSw3ICs1NTUsNiBAQCBzdGF0aWMgc3RydWN0IHBsYXRmb3JtX2RyaXZlciByb2NrY2hpcF9k cm1fcGxhdGZvcm1fZHJpdmVyID0gewo+ICAgCS5wcm9iZSA9IHJvY2tjaGlwX2RybV9wbGF0Zm9y bV9wcm9iZSwKPiAgIAkucmVtb3ZlID0gcm9ja2NoaXBfZHJtX3BsYXRmb3JtX3JlbW92ZSwKPiAg IAkuZHJpdmVyID0gewo+IC0JCS5vd25lciA9IFRISVNfTU9EVUxFLAo+ICAgCQkubmFtZSA9ICJy b2NrY2hpcC1kcm0iLAo+ICAgCQkub2ZfbWF0Y2hfdGFibGUgPSByb2NrY2hpcF9kcm1fZHRfaWRz LAo+ICAgCQkucG0gPSAmcm9ja2NoaXBfZHJtX3BtX29wcywKVGhhbmtzIGZvciB0aGUgZml4LCBh cHBsaWVkIHRvIG15IGRybS1uZXh0IGJyYW5jaCwgOi0pCgotLSAK77ytYXJrCgoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcg bGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: mark.yao@rock-chips.com (Mark yao) Date: Mon, 13 Jul 2015 14:03:02 +0800 Subject: [PATCH v2 2/2] drm/rockchip: Drop owner assignment from platform_driver In-Reply-To: <1436524653-29132-3-git-send-email-k.kozlowski@samsung.com> References: <1436524653-29132-1-git-send-email-k.kozlowski@samsung.com> <1436524653-29132-3-git-send-email-k.kozlowski@samsung.com> Message-ID: <55A35496.5060206@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2015?07?10? 18:37, Krzysztof Kozlowski wrote: > platform_driver does not need to set an owner because > platform_driver_register() will set it. > > Signed-off-by: Krzysztof Kozlowski > > --- > Changes since v1: > 1. Split owner removal from rockchip to separate patch (spotted by Mark > Yao). > --- > drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c > index 01b558fe3695..9a0c2911272a 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c > @@ -555,7 +555,6 @@ static struct platform_driver rockchip_drm_platform_driver = { > .probe = rockchip_drm_platform_probe, > .remove = rockchip_drm_platform_remove, > .driver = { > - .owner = THIS_MODULE, > .name = "rockchip-drm", > .of_match_table = rockchip_drm_dt_ids, > .pm = &rockchip_drm_pm_ops, Thanks for the fix, applied to my drm-next branch, :-) -- ?ark From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751831AbbGMGIj (ORCPT ); Mon, 13 Jul 2015 02:08:39 -0400 Received: from regular2.263xmail.com ([211.157.152.3]:40134 "EHLO regular2.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751407AbbGMGIh (ORCPT ); Mon, 13 Jul 2015 02:08:37 -0400 X-263anti-spam: KSV:0;BIG:0;ABS:1;DNS:0;ATT:0;SPF:S; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ADDR-CHECKED: 0 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: k.kozlowski@samsung.com X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: <477cf41b86524b5a4097191306dfa493> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <55A35496.5060206@rock-chips.com> Date: Mon, 13 Jul 2015 14:03:02 +0800 From: Mark yao User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Krzysztof Kozlowski , David Airlie , Heiko Stuebner , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v2 2/2] drm/rockchip: Drop owner assignment from platform_driver References: <1436524653-29132-1-git-send-email-k.kozlowski@samsung.com> <1436524653-29132-3-git-send-email-k.kozlowski@samsung.com> In-Reply-To: <1436524653-29132-3-git-send-email-k.kozlowski@samsung.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015年07月10日 18:37, Krzysztof Kozlowski wrote: > platform_driver does not need to set an owner because > platform_driver_register() will set it. > > Signed-off-by: Krzysztof Kozlowski > > --- > Changes since v1: > 1. Split owner removal from rockchip to separate patch (spotted by Mark > Yao). > --- > drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c > index 01b558fe3695..9a0c2911272a 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c > @@ -555,7 +555,6 @@ static struct platform_driver rockchip_drm_platform_driver = { > .probe = rockchip_drm_platform_probe, > .remove = rockchip_drm_platform_remove, > .driver = { > - .owner = THIS_MODULE, > .name = "rockchip-drm", > .of_match_table = rockchip_drm_dt_ids, > .pm = &rockchip_drm_pm_ops, Thanks for the fix, applied to my drm-next branch, :-) -- Ｍark