From mboxrd@z Thu Jan 1 00:00:00 1970 From: Juergen Gross Subject: Re: [PATCH V5 7/7] domcreate: support pvusb in configuration file Date: Mon, 13 Jul 2015 12:08:46 +0200 Message-ID: <55A38E2E.60509@suse.com> References: <1435226838-3067-1-git-send-email-cyliu@suse.com> <1435226838-3067-8-git-send-email-cyliu@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1435226838-3067-8-git-send-email-cyliu@suse.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Chunyan Liu , xen-devel@lists.xen.org Cc: wei.liu2@citrix.com, ian.campbell@citrix.com, george.dunlap@eu.citrix.com, Ian.Jackson@eu.citrix.com, jfehlig@suse.com, Simon Cao List-Id: xen-devel@lists.xenproject.org On 06/25/2015 12:07 PM, Chunyan Liu wrote: > Add code to support pvusb in domain config file. One could specify > usbctrl and usb in domain's configuration file and create domain, > then usb controllers will be created and usb device would be attached > to guest automatically. > > One could specify usb controllers and usb devices in config file > like this: > usbctrl=['version=2,ports=4', 'version=1,ports=4', ] > usbdev=['2.1,controller=0,port=1', ] > > Signed-off-by: Chunyan Liu > Signed-off-by: Simon Cao I tested this patch and it still isn't working: config file: usbctrl = [ 'version=2,ports=4', ] usbdev = [ '3.4,controller=0,port=1', ] xl create output: xl: libxl_event.c:1759: libxl__ao_inprogress_gc: Assertion `!ao->complete' failed. I'm not sure, but comparing e.g. libxl__device_disk_add() with libxl__device_usb_add() shows a significant difference regarding passing of ao data. I think you'll need a wrapper as in the disk case and pass NULL for ao to the attach function being capable of async operation when you are calling the attach function during domain creation. Juergen