From: Paolo Bonzini <pbonzini@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Cornelia Huck <cornelia.huck@de.ibm.com>,
qemu-devel@nongnu.org, kraxel@redhat.com
Subject: Re: [Qemu-devel] [PATCH for-2.4] qdev: fix 64 bit properties
Date: Mon, 13 Jul 2015 13:24:37 +0200 [thread overview]
Message-ID: <55A39FF5.9000408@redhat.com> (raw)
In-Reply-To: <20150713142240-mutt-send-email-mst@redhat.com>
On 13/07/2015 13:23, Michael S. Tsirkin wrote:
> On Mon, Jul 13, 2015 at 12:18:31PM +0200, Paolo Bonzini wrote:
>>
>>
>> On 13/07/2015 11:01, Cornelia Huck wrote:
>>> On Thu, 9 Jul 2015 13:01:14 +0200
>>> Cornelia Huck <cornelia.huck@de.ibm.com> wrote:
>>>
>>>> 64 bit props used 32 bit callbacks in two places, leading to broken
>>>> feature bits on virtio (example: got 0x31000000000006d4 which is
>>>> obviously bogus). Fix this.
>>>>
>>>> Fixes: fdba6d96 ("qdev: add 64bit properties")
>>>> Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
>>>> ---
>>>> hw/core/qdev-properties.c | 2 +-
>>>> include/hw/qdev-properties.h | 2 +-
>>>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>> Ping? I think this should go into 2.4-rc1.
>>
>> I'll queue it.
>>
>> Paolo
>
> No need, I already have it queued. Want to send an ack?
Sure,
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
prev parent reply other threads:[~2015-07-13 11:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-09 11:01 [Qemu-devel] [PATCH for-2.4] qdev: fix 64 bit properties Cornelia Huck
2015-07-09 11:22 ` Christian Borntraeger
2015-07-13 9:01 ` Cornelia Huck
2015-07-13 10:18 ` Paolo Bonzini
2015-07-13 11:23 ` Michael S. Tsirkin
2015-07-13 11:24 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A39FF5.9000408@redhat.com \
--to=pbonzini@redhat.com \
--cc=cornelia.huck@de.ibm.com \
--cc=kraxel@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.