Re: [uml-devel] linux-4.2-rc2/arch/um/drivers/net_user.c:258: possible missing call to va_end ?

[Richard Weinberger <richard@nod.at>]

Hi!

Can you please render this into a proper patch and re-send to the mailinglist?

Thanks,
//richard

Am 13.07.2015 um 11:08 schrieb David Binderman:
> Hello there,
> 
> [linux-4.2-rc2/arch/um/drivers/net_user.c:258]: (error) va_list 'ap' was opened but not closed by va_end().
> 
> Source code is
> 
>     va_start(ap, str);
>     while ((arg = va_arg(ap, char **)) != NULL) {
>         if (*str == '\0')
>             return NULL;
>         end = strchr(str, ',');
>         if (end != str)
>             *arg = str;
>         if (end == NULL)
>             return NULL;
>         *end++ = '\0';
>         str = end;
>     }
>     va_end(ap);
>     return str;
> 
> If va_end needs to be called for successful return, it probably also
> needs to be called for NULL return (twice).
> 
> Regards
> 
> David Binderman
> 
>  		 	   		  
> 

------------------------------------------------------------------------------
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel