From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: John Hunter <zhjwpku@gmail.com>, dri-devel@lists.freedesktop.org
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH v2] drm: add a drm_atomic_helper_plane_check_update
Date: Mon, 13 Jul 2015 13:59:33 +0200 [thread overview]
Message-ID: <55A3A825.9020907@linux.intel.com> (raw)
In-Reply-To: <1436788242-19788-1-git-send-email-zhjwpku@gmail.com>
Op 13-07-15 om 13:50 schreef John Hunter:
> From: Zhao Junwang <zhjwpku@gmail.com>
>
> This is the equivalent helper to drm_plane_helper_check_update
> for legacy drivers, but using atomic state to check things.
>
> Motivated by the atomic conversion of the bochs driver.
>
> v2: according to Daniel's comment
> -polish the kerneldoc comment to match the signatures
> -crtc->mode is legacy state, we need to look at crtc_state
> instead
>
> according to Maarten's comment
> -there is no need for can_update_disabled in the atomic world,
> so, we can delete that parameter
>
> v3: according to Daniel's comment
> -this function call can't fail, add a WARN_ON
> -use drm_atomic_get_existing_crtc_state
>
> according to Maarten's comment
> -kill off the plane parameter and rename state to plane_state
> -do not handling NULL, i.e. no need to check plane_state in
> atomic.
>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Signed-off-by: Zhao Junwang <zhjwpku@gmail.com>
Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-07-13 11:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-13 11:50 [PATCH v2] drm: add a drm_atomic_helper_plane_check_update John Hunter
2015-07-13 11:59 ` Maarten Lankhorst [this message]
2015-07-13 14:14 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A3A825.9020907@linux.intel.com \
--to=maarten.lankhorst@linux.intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=zhjwpku@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.