From: Gregor Riepl <onitake@gmail.com>
To: Robert Dolca <robert.dolca@gmail.com>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH] Add generic driver for Silead tochscreens
Date: Mon, 13 Jul 2015 14:21:17 +0200 [thread overview]
Message-ID: <55A3AD3D.4040008@gmail.com> (raw)
In-Reply-To: <CAFPB+YdNTUCRsQZZVCZQGyAdmOnSGs_fqOFxRm9u8rFPLDobCQ@mail.gmail.com>
> The firmware has to be calibrated by the vendor for each chip-panel
> combination. If you change the panel even if you keep the same chip it
> is very likely to need some calibration. This might be the reason why
> the finger ID is not working properly.
I see.
So, while your new driver is sufficiently generic, it would still need a
device specific firmware image and there is no way to work around that?
That's kind of a bummer.
Would it be possible to modify the driver in a way that it would work with
different types of panels/chips, even those where finger tracking does not
work correctly?
Also, I see one particular problem concerning existing hardware.
You're retrieving the dimensions, maximum number of trackable fingers and the
name of the firmware image from the DSDT or DTS using device_property_read_*.
The Baytrail tablet I'm testing on does not include such information, and
injecting a modified DSDT is maybe not the best option. Also, the DSDT shipped
I have here does not use GPIO definitions for the control pins, but instead
executes the shutdown/wakeup sequences through _PS3/_PS0 methods. At least
that was my assumption when I looked at it. There are GPIO definitions as
well, but it's not clear what those are used for. Please take a look at the
stanza yourself, if you can:
https://github.com/onitake/gslx680-acpi/blob/master/acpi/gsl-dsdt.aml
I can also send you the complete decompiled DSDT if it helps.
next prev parent reply other threads:[~2015-07-13 12:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-11 21:23 [PATCH] Add generic driver for Silead tochscreens Gregor Riepl
2015-07-12 6:31 ` Dmitry Torokhov
2015-07-13 9:59 ` Robert Dolca
2015-07-13 12:21 ` Gregor Riepl [this message]
2015-07-13 14:24 ` Gregor Riepl
2015-07-13 14:52 ` Robert Dolca
2015-07-13 15:18 ` Gregor Riepl
2015-07-16 13:59 ` Gregor Riepl
2015-07-20 21:19 ` Robert Dolca
2015-07-20 21:13 ` Robert Dolca
2015-07-21 13:21 ` Gregor Riepl
-- strict thread matches above, loose matches on Subject: below --
2015-07-10 15:11 Robert Dolca
2015-07-11 13:05 ` Paul Bolle
2015-07-20 6:51 ` Dmitry Torokhov
2015-07-20 12:05 ` Robert Dolca
2015-07-27 21:30 ` Dmitry Torokhov
2015-07-28 7:23 ` Robert Dolca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A3AD3D.4040008@gmail.com \
--to=onitake@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=robert.dolca@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.