All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jacek Anaszewski <j.anaszewski@samsung.com>
To: Axel Lin <axel.lin@ingics.com>
Cc: Bryan Wu <cooloney@gmail.com>, Dan Murphy <dmurphy@ti.com>,
	linux-leds@vger.kernel.org
Subject: Re: [PATCH] leds: lp8860: Constify reg_default tables
Date: Mon, 13 Jul 2015 14:50:09 +0200	[thread overview]
Message-ID: <55A3B401.40900@samsung.com> (raw)
In-Reply-To: <1436323406.25341.0.camel@ingics.com>

Hi Axel,

Thanks for the patch.

On 07/08/2015 04:43 AM, Axel Lin wrote:
> These reg_default tables are not modified after initialized, so make them
> const.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
>   drivers/leds/leds-lp8860.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/leds/leds-lp8860.c b/drivers/leds/leds-lp8860.c
> index 8c2b7fb..79f0843 100644
> --- a/drivers/leds/leds-lp8860.c
> +++ b/drivers/leds/leds-lp8860.c
> @@ -302,7 +302,7 @@ out:
>   	return ret;
>   }
>
> -static struct reg_default lp8860_reg_defs[] = {
> +static const struct reg_default lp8860_reg_defs[] = {
>   	{ LP8860_DISP_CL1_BRT_MSB, 0x00},
>   	{ LP8860_DISP_CL1_BRT_LSB, 0x00},
>   	{ LP8860_DISP_CL1_CURR_MSB, 0x00},
> @@ -332,7 +332,7 @@ static const struct regmap_config lp8860_regmap_config = {
>   	.cache_type = REGCACHE_NONE,
>   };
>
> -static struct reg_default lp8860_eeprom_defs[] = {
> +static const struct reg_default lp8860_eeprom_defs[] = {
>   	{ LP8860_EEPROM_REG_0, 0x00 },
>   	{ LP8860_EEPROM_REG_1, 0x00 },
>   	{ LP8860_EEPROM_REG_2, 0x00 },
>

Acked-by: Jacek Anaszewski <j.anaszewski@samsung.com>

-- 
Best Regards,
Jacek Anaszewski

      reply	other threads:[~2015-07-13 12:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-08  2:43 [PATCH] leds: lp8860: Constify reg_default tables Axel Lin
2015-07-13 12:50 ` Jacek Anaszewski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55A3B401.40900@samsung.com \
    --to=j.anaszewski@samsung.com \
    --cc=axel.lin@ingics.com \
    --cc=cooloney@gmail.com \
    --cc=dmurphy@ti.com \
    --cc=linux-leds@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.