From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48822) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZEekQ-0002op-Ik for qemu-devel@nongnu.org; Mon, 13 Jul 2015 10:30:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZEekN-0004Dn-61 for qemu-devel@nongnu.org; Mon, 13 Jul 2015 10:30:22 -0400 Received: from e06smtp10.uk.ibm.com ([195.75.94.106]:55741) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZEekM-0004DA-Sz for qemu-devel@nongnu.org; Mon, 13 Jul 2015 10:30:19 -0400 Received: from /spool/local by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 13 Jul 2015 15:30:17 +0100 Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id ECD5B2190046 for ; Mon, 13 Jul 2015 15:29:52 +0100 (BST) Received: from d06av01.portsmouth.uk.ibm.com (d06av01.portsmouth.uk.ibm.com [9.149.37.212]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t6DEUF7v38797518 for ; Mon, 13 Jul 2015 14:30:15 GMT Received: from d06av01.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av01.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t6DEUETO025093 for ; Mon, 13 Jul 2015 08:30:15 -0600 Message-ID: <55A3CB76.4070803@de.ibm.com> Date: Mon, 13 Jul 2015 16:30:14 +0200 From: Christian Borntraeger MIME-Version: 1.0 References: <1436460692-5142-1-git-send-email-cornelia.huck@de.ibm.com> <1436460692-5142-2-git-send-email-cornelia.huck@de.ibm.com> <55A3AD6D.5010303@de.ibm.com> <20150713161152.3e519fcd.cornelia.huck@de.ibm.com> <55A3C919.1040400@suse.de> In-Reply-To: <55A3C919.1040400@suse.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH for-2.4 1/2] core: reset handler for bus-less devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?windows-1252?Q?Andreas_F=E4rber?= , Cornelia Huck Cc: peter.crosthwaite@xilinx.com, gesaint@linux.vnet.ibm.com, jfrei@linux.vnet.ibm.com, qemu-devel@nongnu.org, agraf@suse.de Am 13.07.2015 um 16:20 schrieb Andreas Färber: > Am 13.07.2015 um 16:11 schrieb Cornelia Huck: >> On Mon, 13 Jul 2015 14:22:05 +0200 >> Christian Borntraeger wrote: >> >>> Am 09.07.2015 um 18:51 schrieb Cornelia Huck: >>>> Devices that don't live on a bus aren't caught by the normal device >>>> reset logic. Let's register a reset handler for those devices during >>>> device realization that calls the reset handler for the associated >>>> device class. >>>> >>>> Suggested-by: Peter Crosthwaite >>>> Signed-off-by: Cornelia Huck >>> reboot (from within guest) and external reset (system_reset in monitor) >>> now work fine with the s390 watchdog. >>> >>> Tested-by: Christian Borntraeger >>> >>>> --- >>>> hw/core/qdev.c | 15 +++++++++++++++ >>>> 1 file changed, 15 insertions(+) >> >> Thanks. >> >> Any objections against taking this through s390-next? I'd like to fix >> diag288 reset (+ that annoying migration regession) for 2.4-rc1 and >> send a pull request soon. > > Which device does this fix (only this diag88?), and is it really not > possible to register a reset handler where it's being created? A sysbus device reset is also not registered or called by its parent. It is resetted by the generic qdev handler walking all children (qdev_reset_all and qbus_reset_all), no? Christian