From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48783)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Leon.Alrae@imgtec.com>) id 1ZEgAO-0007J4-Ju
	for qemu-devel@nongnu.org; Mon, 13 Jul 2015 12:01:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Leon.Alrae@imgtec.com>) id 1ZEgAJ-00064G-IP
	for qemu-devel@nongnu.org; Mon, 13 Jul 2015 12:01:16 -0400
Received: from mailapp01.imgtec.com ([195.59.15.196]:23610)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Leon.Alrae@imgtec.com>) id 1ZEgAJ-0005v8-DN
	for qemu-devel@nongnu.org; Mon, 13 Jul 2015 12:01:11 -0400
Message-ID: <55A3E0B6.2090102@imgtec.com>
Date: Mon, 13 Jul 2015 17:00:54 +0100
From: Leon Alrae <leon.alrae@imgtec.com>
MIME-Version: 1.0
References: <cover.1436665556.git.crosthwaite.peter@gmail.com>
	<50def3c16a368c2d5157a2bc18ab604ec6ecc914.1436665556.git.crosthwaite.peter@gmail.com>
In-Reply-To: <50def3c16a368c2d5157a2bc18ab604ec6ecc914.1436665556.git.crosthwaite.peter@gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 7/8] disas: mips: QOMify target specific
	disas setup
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Crosthwaite <crosthwaitepeter@gmail.com>, qemu-devel@nongnu.org
Cc: afaerber@suse.de, Aurelien Jarno <aurelien@aurel32.net>, Peter Crosthwaite <crosthwaite.peter@gmail.com>

On 12/07/2015 03:00, Peter Crosthwaite wrote:
> From: Peter Crosthwaite <crosthwaitepeter@gmail.com>
> 
> Move the target_disas() mips specifics to the QOM disas_set_info hook
> and delete the #ifdef specific code in disas.c.
> 
> Cc: Aurelien Jarno <aurelien@aurel32.net>
> Cc: Leon Alrae <leon.alrae@imgtec.com>
> Signed-off-by: Peter Crosthwaite <crosthwaite.peter@gmail.com>
> ---
> Testing:
> mips-test$ ./run-qemu -d in_asm -S 2> err
> QEMU 2.3.90 monitor - type 'help' for more information
> (qemu) x/i 0xbfc00000
> 0xbfc00000:  j  0xbfc00580
> (qemu) c
> (qemu) q
> 
> mips-test$ more err
> IN:
> 0xbfc00000:  j  0xbfc00580
> 0xbfc00004:  nop
> 
> IN:
> 0xbfc00580:  li a0,2
> 0xbfc00584:  lui    sp,0x8000
> ...
> ---
>  disas.c           | 12 ------------
>  target-mips/cpu.c | 10 ++++++++++
>  2 files changed, 10 insertions(+), 12 deletions(-)

Acked-by: Leon Alrae <leon.alrae@imgtec.com>