From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 6311AE00A1E; Mon, 13 Jul 2015 09:30:49 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [74.125.82.52 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Received: from mail-wg0-f52.google.com (mail-wg0-f52.google.com [74.125.82.52]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 2D799E008EC for ; Mon, 13 Jul 2015 09:30:36 -0700 (PDT) Received: by wgmn9 with SMTP id n9so47379753wgm.0 for ; Mon, 13 Jul 2015 09:30:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=do3Dc+E0FtZe59RGcH/r57a51ppQ55aovkon3cif3b8=; b=YL9vcjrs9zHsyAva4dHEw7jBu6QMQgNFFM6KBIlOEmI8pKeYUsBJ43yGKXGoi9EONT Zt+4dRXSUeLnGtRbQ02FQ6+/TK3j7qwURxN4YaGVc1OESSetgKxyuSmAc9vSJuYOhgIe IMlV4O9yJmVZcIx6ibFy3a9te+mhHjzb9c41PLt5tYq4riLklEQKLyCrXa5Rvn8dJnpE 2nfQDIJBgb8Yso82Q3EgazfblNe+IMVRCoV0y9UM+OrrdTz/KBzifZ7+1wOhJv7/wt57 q12d2+kWwl2w0S1hiPoCoakUztoJMvVoovecSmFxUNiz+/HSdKxaKq2h2T6yHmUwzRcN Bqvg== X-Gm-Message-State: ALoCoQn246Iu9iMLM7hTJFuQNt9gmlfnvw418SE8BtgsqosLF3GKPfHXJLCQDotMM+oAdPB31K3y X-Received: by 10.180.24.165 with SMTP id v5mr24579882wif.63.1436805035676; Mon, 13 Jul 2015 09:30:35 -0700 (PDT) Received: from [192.168.2.178] ([83.217.123.106]) by smtp.googlemail.com with ESMTPSA id q3sm30075029wjr.38.2015.07.13.09.30.34 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 Jul 2015 09:30:35 -0700 (PDT) Message-ID: <55A3E7AA.10704@intel.com> Date: Mon, 13 Jul 2015 17:30:34 +0100 From: Michael Wood User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: toaster@yoctoproject.org References: In-Reply-To: Subject: Re: [review-request] adamian/20150707_bugs X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jul 2015 16:30:49 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Could you include the summary of each of the commits for review so that we can be sure which patches are the new ones * 3b0073f bitbake: toaster: fix updates on failed build requests * 1bdd687 bitbake: toaster: replace raising Exceptions in loadconf * 99a626a bitbake: toaster: do not stop data import on bad data Look fine to me * 4fc46e7 bitbake: toastergui: fixing pylint warnings This one needs splitting up, pylint fixes, logging fixes , string to int casting, etc Thanks, Michael On 08/07/15 15:52, Barros Pena, Belen wrote: > > On 07/07/2015 17:27, "Damian, Alexandru" > wrote: > >> Hi, >> >> >> I have some comments below, >> >> >> Alex >> >> On Tue, Jul 7, 2015 at 3:54 PM, Barros Pena, Belen >> wrote: >> >> >> >> On 07/07/2015 15:10, "Damian, Alexandru" >> wrote: >> >>> Hello, >>> >>> >>> I'm pushing two patches for review >>> >>> >>> - one is fixing 7955 >> Thanks for the quick fix, Alex! I've tested this on master, and I've >> noticed a couple of things: >> >> 1. The invalid data from the layer index causes warnings when importing >> the information. This might be because the debug mode is enabled, though, >> but I thought I'd bringing it up just in case. >> >> ​This happens because data doesn't match what Toaster expect - Toaster >> has a bit stricter ​requirements than Layer Index. I would expect that >> the warning messages are helpful to the user, and they should not be >> obscured. If a particular user wishes to not see some of the messages, >> they can set up the debug level to something higher in settings.py. Or we >> can ship with a higher debug level by default, but I don't think we >> should silently ignore bad data. > Sure: I can see your point. I was only bringing it up, but I am not sure > what's best, to be honest: showing them or not. As you said, falling > silent doesn't sound right; on the other hand, the messages look a bit > alarming. > > >> 2. I can see at least one recipe in the 'all recipes' table without a >> name. This particular one is provided by meta-ivi. You can add the layer >> and you get a build button, which you can click, although when you do so >> the build does not seem to start. I think we need to hide any recipes that >> do not have a name from the list. They are invalid, and should not be >> exposed to users. >> >> ​We can add such a check, of course, on imported data. I would say this >> is the object of a different bug report, though. > Done! https://bugzilla.yoctoproject.org/show_bug.cgi?id=7969 > >> Also, I think we are going to need to back port the fix to Fido. > Is back porting ok? Should we track this somehow? > > Thanks! > > Belén > >> Cheers >> >> Belén >> >>> - one is fixing various issues highlighted by pylint >>> >>> >>> https://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=adamian/20 >>> 1 >>> 50707_bugs >>> >>> >>> >>> ​Can you please review ? >>> >>> >>> Cheers, >>> Alex​ >>> >>> >>> >>> >>> -- >>> Alex Damian >>> Yocto Project >>> >>> SSG / OTC >>> >>> >>> >> >> >> >> >> >> >> >> >> >> -- >> Alex Damian >> Yocto Project >> >> SSG / OTC >> >> >> >>