From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v4 16/17] xen/arm: ITS: Generate ITS node for Dom0 Date: Mon, 13 Jul 2015 19:31:32 +0200 Message-ID: <55A3F5F4.8050409@citrix.com> References: <1436514172-3263-1-git-send-email-vijay.kilari@gmail.com> <1436514172-3263-17-git-send-email-vijay.kilari@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Stefano Stabellini , vijay.kilari@gmail.com Cc: Ian.Campbell@citrix.com, Prasun.Kapoor@caviumnetworks.com, Vijaya Kumar K , tim@xen.org, xen-devel@lists.xen.org, stefano.stabellini@citrix.com, manish.jaggi@caviumnetworks.com List-Id: xen-devel@lists.xenproject.org Hi Stefano, On 13/07/2015 18:32, Stefano Stabellini wrote: > > All these #ifdefs are a bit ugly. Couldn't we just build this code > always, even on arm32, relying on dt_match_node not to match in that > case? I'm not in favor of any ITS code in the common code unless it's strictly necessary. In this specific case, the number of ITS between DOM0 and the hardware may be different. Per the design document, we only support 1 virtual ITS. Furthermore, on the version 3 of this patch [1], I said that it's possible to do it in the hwdom_dt_callback and avoid all this mess in a function which only browse the device tree. Regards, [1] http://lists.xen.org/archives/html/xen-devel/2015-07/msg01092.html -- Julien Grall