All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hartmut Knaack <knaack.h@gmx.de>
To: Cristina Opriceana <cristina.opriceana@gmail.com>, jic23@kernel.org
Cc: lars@metafoo.de, pmeerw@pmeerw.net, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org, daniel.baluta@intel.com,
	octavian.purdila@intel.com
Subject: Re: [PATCH 2/3] tools: iio: Remove unnecessary braces
Date: Mon, 13 Jul 2015 20:48:32 +0200	[thread overview]
Message-ID: <55A40800.1080805@gmx.de> (raw)
In-Reply-To: <45661e14b247cebfc130518e0c1c44fcec339f0d.1436789446.git.cristina.opriceana@gmail.com>

Cristina Opriceana schrieb am 13.07.2015 um 15:17:
> Single statement blocks don’t need braces.
> Found with checkpatch.pl.
> 
> Signed-off-by: Cristina Opriceana <cristina.opriceana@gmail.com>
Acked-by: Hartmut Knaack <knaack.h@gmx.de>
> ---

Oops, that slipped through my hands. Thanks for taking care of this.

>  tools/iio/iio_event_monitor.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/tools/iio/iio_event_monitor.c b/tools/iio/iio_event_monitor.c
> index 703f4cb..9ee1959 100644
> --- a/tools/iio/iio_event_monitor.c
> +++ b/tools/iio/iio_event_monitor.c
> @@ -262,9 +262,8 @@ int main(int argc, char **argv)
>  		printf("Found IIO device with name %s with device number %d\n",
>  		       device_name, dev_num);
>  		ret =sprintf(&chrdev_name, "/dev/iio:device%d", dev_num);
> -		if (ret < 0) {
> +		if (ret < 0)
>  			return -ENOMEM;
> -		}
>  	} else {
>  		/*
>  		 * If we can't find an IIO device by name assume device_name is
> 


  reply	other threads:[~2015-07-13 18:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-13 13:13 [PATCH 0/3] tools: iio: Fix style issues Cristina Opriceana
2015-07-13 13:15 ` [PATCH 1/3] tools: iio: Remove explicit NULL comparison Cristina Opriceana
2015-07-13 18:46   ` Hartmut Knaack
2015-07-19 14:01     ` Jonathan Cameron
2015-07-13 13:17 ` [PATCH 2/3] tools: iio: Remove unnecessary braces Cristina Opriceana
2015-07-13 18:48   ` Hartmut Knaack [this message]
2015-07-19 14:02     ` Jonathan Cameron
2015-07-13 13:20 ` [PATCH 3/3] tools: iio: Add ARRAY_SIZE macro Cristina Opriceana
2015-07-13 18:49   ` Hartmut Knaack
2015-07-19 14:03     ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55A40800.1080805@gmx.de \
    --to=knaack.h@gmx.de \
    --cc=cristina.opriceana@gmail.com \
    --cc=daniel.baluta@intel.com \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=octavian.purdila@intel.com \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.