From: Ellen Wang <ellen-qUQiAmfTcIp+XZJcv9eMoEEOCMrvLtNR@public.gmane.org>
To: Jiri Kosina <jkosina-IBi9RG/b67k@public.gmane.org>
Cc: borneo.antonio-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
dbarksdale-2SNLKkHU5xRBDgjK7y7TUQ@public.gmane.org,
linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v1] HID: cp2112: fix I2C_SMBUS_BYTE write
Date: Mon, 13 Jul 2015 15:28:25 -0700 [thread overview]
Message-ID: <55A43B89.6050600@cumulusnetworks.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1507131320060.7522-ztGlSCb7Y1iN3ZZ/Hiejyg@public.gmane.org>
On 7/13/2015 4:20 AM, Jiri Kosina wrote:
> On Thu, 9 Jul 2015, Ellen Wang wrote:
>
>> When doing an I2C_SMBUS_BYTE write (one byte write, no address),
>> the data to be written is in "command" not "data->byte".
>
> This is missing Signoff.
Sorry. I submitted v2.
> How serious is this bug in practice? Is this 4.2 material?
The driver segfaults without the fix, and this is a common operation.
On the other hand, the cp2112 is an uncommon device.
(I would personally like all the cp2112 fixes to be in 4.1 eventually.
They are all important functional improvements.)
prev parent reply other threads:[~2015-07-13 22:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-10 5:07 [PATCH v1] HID: cp2112: fix I2C_SMBUS_BYTE write Ellen Wang
2015-07-13 11:20 ` Jiri Kosina
[not found] ` <alpine.LNX.2.00.1507131320060.7522-ztGlSCb7Y1iN3ZZ/Hiejyg@public.gmane.org>
2015-07-13 22:28 ` Ellen Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A43B89.6050600@cumulusnetworks.com \
--to=ellen-quqiamftcip+xzjcv9emoeeocmrvltnr@public.gmane.org \
--cc=borneo.antonio-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=dbarksdale-2SNLKkHU5xRBDgjK7y7TUQ@public.gmane.org \
--cc=jkosina-IBi9RG/b67k@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.