All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexei Starovoitov <ast@plumgrid.com>
To: He Kuang <hekuang@huawei.com>,
	rostedt@goodmis.org, masami.hiramatsu.pt@hitachi.com,
	acme@kernel.org, a.p.zijlstra@chello.nl, mingo@redhat.com,
	namhyung@kernel.org, jolsa@kernel.org
Cc: wangnan0@huawei.com, pi3orama@163.com, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v5 3/3] bpf: Introduce function for outputing trace event data
Date: Mon, 13 Jul 2015 20:08:20 -0700	[thread overview]
Message-ID: <55A47D24.5010703@plumgrid.com> (raw)
In-Reply-To: <1436839171-31527-4-git-send-email-hekuang@huawei.com>

On 7/13/15 6:59 PM, He Kuang wrote:
> There're scenarios that we need an eBPF program to record not only
> kprobe point args, but also the PMU counters, time latencies or the
> number of cache misses between two probe points and other information
> when the probe point is entered.
>
> This patch adds a new trace event to establish infrastruction for bpf to
> output data to perf. Userspace perf tools can detect and use this event
> as using the existing tracepoint events.
>
> New bpf trace event entry in debugfs:
>
>       /sys/kernel/debug/tracing/events/bpf/bpf_output_data
>
> Userspace perf tools detect the new tracepoint event as:
>
>       bpf:bpf_output_data                          [Tracepoint event]
>
> Data in ring-buffer of perf events added to this event will be polled
> out, sample types and other attributes can be adjusted to those events
> directly without touching the original kprobe events.
>
> The bpf helper function gives eBPF program ability to output data as
> perf sample event. This helper simple call the new trace event and
> userspace perf tools can record the BPF ftrace event to collect those
> records.
>
> Signed-off-by: He Kuang<hekuang@huawei.com>

Looks good to me.
Acked-by: Alexei Starovoitov <ast@plumgrid.com>


  reply	other threads:[~2015-07-14  3:08 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-14  1:59 [RFC PATCH v5 0/3] Make eBPF programs output data to perf He Kuang
2015-07-14  1:59 ` [RFC PATCH v5 1/3] tracing/events: Fix wrong sample output by storing array length instead of size He Kuang
2015-07-14  1:59 ` [RFC PATCH v5 2/3] tools lib traceevent: Add function to get dynamic arrays length He Kuang
2015-07-17  3:36   ` Wangnan (F)
2015-07-17 14:36     ` Steven Rostedt
2015-07-17 14:43       ` pi3orama
2015-07-14  1:59 ` [RFC PATCH v5 3/3] bpf: Introduce function for outputing trace event data He Kuang
2015-07-14  3:08   ` Alexei Starovoitov [this message]
2015-07-14  3:10 ` [RFC PATCH v5 0/3] Make eBPF programs output data to perf Alexei Starovoitov
2015-07-14 13:35   ` Steven Rostedt
2015-07-17  2:31     ` He Kuang
2015-07-17  2:38       ` Steven Rostedt
2015-07-17  2:39       ` Wangnan (F)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55A47D24.5010703@plumgrid.com \
    --to=ast@plumgrid.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@kernel.org \
    --cc=hekuang@huawei.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=pi3orama@163.com \
    --cc=rostedt@goodmis.org \
    --cc=wangnan0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.