From: "Chen, Tiejun" <tiejun.chen@intel.com>
To: "Michael S. Tsirkin" <mst@redhat.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: qemu-devel@nongnu.org, pbonzini@redhat.com, ehabkost@redhat.com,
rth@twiddle.net
Subject: Re: [Qemu-devel] [v9][PATCH 08/10] xen, gfx passthrough: register a isa bridge
Date: Tue, 14 Jul 2015 16:42:44 +0800 [thread overview]
Message-ID: <55A4CB84.90404@intel.com> (raw)
In-Reply-To: <20150713200122-mutt-send-email-mst@redhat.com>
>>> diff --git a/include/hw/xen/xen.h b/include/hw/xen/xen.h
>>> index 4356af4..703148e 100644
>>> --- a/include/hw/xen/xen.h
>>> +++ b/include/hw/xen/xen.h
>>> @@ -51,4 +51,5 @@ void xen_register_framebuffer(struct MemoryRegion *mr);
>>> # define HVM_MAX_VCPUS 32
>>> #endif
>>>
>>> +extern void igd_passthrough_isa_bridge_create(PCIBus *bus, uint16_t gpu_dev_id);
>>> #endif /* QEMU_HW_XEN_H */
>>
>> You are right that I was confused on my previous comment, but it is true
>> that it shouldn't be part of this patch: it should be part of patch
Right.
>> 7/10. Also the declaration should probably not be in the xen.h header.
>>
>> Michael, where do you think should go?
>
> Donnu - add a header?
>
What about the include/hw/i386/pc.h file?
Thanks
Tiejun
next prev parent reply other threads:[~2015-07-14 8:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-07 5:33 [Qemu-devel] [v9][PATCH 00/10] xen: add Intel IGD passthrough Tiejun Chen
2015-07-07 5:33 ` [Qemu-devel] [v9][PATCH 01/10] i440fx: make types configurable at run-time Tiejun Chen
2015-07-07 5:33 ` [Qemu-devel] [v9][PATCH 02/10] pc_init1: pass parameters just with types Tiejun Chen
2015-07-07 5:33 ` [Qemu-devel] [v9][PATCH 03/10] piix: create host bridge to passthrough Tiejun Chen
2015-07-07 5:33 ` [Qemu-devel] [v9][PATCH 04/10] hw/pci-assign: split pci-assign.c Tiejun Chen
2015-07-07 5:33 ` [Qemu-devel] [v9][PATCH 05/10] xen, gfx passthrough: basic graphics passthrough support Tiejun Chen
2015-07-07 5:33 ` [Qemu-devel] [v9][PATCH 06/10] xen, gfx passthrough: retrieve VGA BIOS to work Tiejun Chen
2015-07-07 5:33 ` [Qemu-devel] [v9][PATCH 07/10] igd gfx passthrough: create a isa bridge Tiejun Chen
2015-07-07 5:33 ` [Qemu-devel] [v9][PATCH 08/10] xen, gfx passthrough: register " Tiejun Chen
2015-07-13 16:14 ` Stefano Stabellini
2015-07-13 17:01 ` Michael S. Tsirkin
2015-07-14 8:42 ` Chen, Tiejun [this message]
2015-07-14 8:49 ` Michael S. Tsirkin
2015-07-07 5:33 ` [Qemu-devel] [v9][PATCH 09/10] xen, gfx passthrough: register host bridge specific to passthrough Tiejun Chen
2015-07-13 16:16 ` Stefano Stabellini
2015-07-07 5:33 ` [Qemu-devel] [v9][PATCH 10/10] xen, gfx passthrough: add opregion mapping Tiejun Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A4CB84.90404@intel.com \
--to=tiejun.chen@intel.com \
--cc=ehabkost@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefano.stabellini@eu.citrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.