All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] Makefile: create $(BUILD_DIR) before attempting to touch .root
Date: Tue, 14 Jul 2015 11:46:52 +0200	[thread overview]
Message-ID: <55A4DA8C.1030104@mind.be> (raw)
In-Reply-To: <1436867048-6333-1-git-send-email-patrickdepinguin@gmail.com>

On 07/14/15 11:44, Thomas De Schampheleire wrote:
> From: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>

Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

 Regards,
 Arnout

> 
> The target $(BUILD_DIR)/.root does not have a direct dependency on
> $(BUILD_DIR), meaning that cases could exist where the target is executed
> without $(BUILD_DIR) being present.
> Instead of hoping on a specific order, and instead of adding new make
> dependencies, just make sure the directory is created.
> 
> Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index 8eb8c6d..ee65417 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -471,7 +471,7 @@ RSYNC_VCS_EXCLUSIONS = \
>  	--exclude CVS
>  
>  $(BUILD_DIR)/.root:
> -	mkdir -p $(TARGET_DIR)
> +	mkdir -p $(TARGET_DIR) $(BUILD_DIR)
>  	rsync -a --ignore-times $(RSYNC_VCS_EXCLUSIONS) \
>  		--chmod=u=rwX,go=rX --exclude .empty --exclude '*~' \
>  		$(TARGET_SKELETON)/ $(TARGET_DIR)/
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

  reply	other threads:[~2015-07-14  9:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-14  9:44 [Buildroot] [PATCH 1/1] Makefile: create $(BUILD_DIR) before attempting to touch .root Thomas De Schampheleire
2015-07-14  9:46 ` Arnout Vandecappelle [this message]
2015-07-14  9:49   ` Thomas De Schampheleire
2015-07-14 15:40 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55A4DA8C.1030104@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.