Re: [PATCH 1/2] libata: add ATA_HORKAGE_NOTRIM

[Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>]

On 7/14/2015 3:16 PM, arne_f wrote:

>>> sone disks lose data at trim also with disabled ncq
>>> so this add a switch to force disable trim.

>>    You forgot to sign off on the patch, so it can't be applied.

> Ok. Next time i will not forget the "-s"

>> [...]
>>> diff --git a/drivers/ata/libata-transport.c b/drivers/ata/libata-transport.c
>>> index d6c37bc..3a13c7d 100644
>>> --- a/drivers/ata/libata-transport.c
>>> +++ b/drivers/ata/libata-transport.c
>>> @@ -569,6 +569,8 @@ show_ata_dev_trim(struct device *dev,
>>>
>>>       if (!ata_id_has_trim(ata_dev->id))
>>>           mode = "unsupported";
>>> +    else if (ata_dev->horkage & ATA_HORKAGE_NOTRIM)
>>> +            mode = "forced_unsupported";
>>
>>    Indented too much.

> Should i change this to "unsupported" or better to something else?

   I just meant the line started too far to the right, that's all.

> Greets,
> Arne

MBR, Sergei