Re: [PATCH] fix host max depth checking for the 'queue_depth' sysfs interface

[Hannes Reinecke <hare@suse.de>]

On 07/14/2015 04:04 PM, Jens Axboe wrote:
> On 07/14/2015 05:22 AM, Hannes Reinecke wrote:
>> On 07/14/2015 09:13 AM, Christoph Hellwig wrote:
>>> Looks good:
>>>
>>> Reviewed-by: Christoph Hellwig <hch@lst.de>
>>>
>>> I wonder if we should start to gradually phase out these tuables
>>> in the
>>> host template.  It's not really more complicated to set them
>>> directly
>>> in the host anyway.
>>
>> Fully agreed. I would vote for making the host template read-only
>> and modify all drivers to use the shost setting.
> 
> Indeed, that would be a much saner choice. The settings in a
> (effectively already) read-only host template seems like somewhat of
> a relic.
> 
Plus some drivers have the habit of modifying the template based on
the settings _for this particular_ device, which leads to
interesting results if you have several devices with _different_
settings ...

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		               zSeries & Storage
hare@suse.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html