From: Steve Dickson <SteveD@redhat.com>
To: Christoph Hellwig <hch@infradead.org>,
Kinglong Mee <kinglongmee@gmail.com>
Cc: "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH v3] blkmapd: Skip the SCSI ID if data length is zero
Date: Tue, 14 Jul 2015 10:35:16 -0400 [thread overview]
Message-ID: <55A51E24.6000502@RedHat.com> (raw)
In-Reply-To: <20150714071537.GB31117@infradead.org>
On 07/14/2015 03:15 AM, Christoph Hellwig wrote:
>> + /* Needs an SCSI ID with unique date not zero length */
>> + if (!dev_id->len)
>> + continue;
>
> That explains what the code does, not why it does so.
>
> How about:
>
> /*
> * Some buggy targets (e.g. VMWare) export zero length
> * EVPD pages, skip them to not confuse the device id
> * cache.
> */
>
I'm not a big fan of calling out vendors in comments. I'm thinking
dropping the "buggy" and "(e.g. VMWare)" would be appropriated.
steved.
prev parent reply other threads:[~2015-07-14 14:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-12 23:57 [PATCH] blkmapd: Skip the SCSI ID if the data length is zero Kinglong Mee
2015-07-13 6:42 ` Christoph Hellwig
2015-07-13 8:24 ` [PATCH v2] blkmapd: Skip the SCSI ID if " Kinglong Mee
2015-07-13 9:01 ` Christoph Hellwig
2015-07-13 9:11 ` Kinglong Mee
2015-07-13 9:59 ` [PATCH v3] " Kinglong Mee
2015-07-14 7:15 ` Christoph Hellwig
2015-07-14 14:11 ` [PATCH v4] " Kinglong Mee
2015-07-14 14:54 ` Steve Dickson
2015-07-14 18:06 ` Steve Dickson
2015-07-14 14:35 ` Steve Dickson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A51E24.6000502@RedHat.com \
--to=steved@redhat.com \
--cc=hch@infradead.org \
--cc=kinglongmee@gmail.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.