From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id C6A25E0095C; Tue, 14 Jul 2015 08:42:20 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [209.85.212.172 listed in list.dnswl.org] Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com [209.85.212.172]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 84929E0086D for ; Tue, 14 Jul 2015 08:42:16 -0700 (PDT) Received: by wiga1 with SMTP id a1so103344627wig.0 for ; Tue, 14 Jul 2015 08:42:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=Ztk6IfceOATv/Bf+z1NhKde+E4AamYDdbR5pxKC4sto=; b=HMw00B3kQRqoDbqxam/KPtV4yujvdTMk5rl9k+94+mxUSbBVmAjyy/jJbgSvWnc7oI v2+VXIIeubkKm3zhzyhelxXnoNSXoeQGpcORRB+Jo83io4A7D7ZB8E17i5B/8nYRGzxj VcW2oDG06z0Fu1Z46PfsH1cwYbyPrNeNh607Q7HpB1knr9RPFvG+gMvjjs3Bl1Ru9M8y e1dqhxA2RxThYxcwFmMhQbZbbVOZNkGPpKeJfYHFIxm0bfG09t6XmD1iyH+uCiXwXhsN NJYEXmLx99B6IPZebPSviavJb1fi/2XqEKQixYkj93n0LXi5ghJuZOrWvTtLSabnpviA Gdxg== X-Gm-Message-State: ALoCoQnSAqzAHOIFGmoMROqdtzgbU+lugQAUpU16mqxeld4ZfmUfQGVetvohhIZGW8LSPgUxtgCA X-Received: by 10.194.71.135 with SMTP id v7mr74562799wju.83.1436888535394; Tue, 14 Jul 2015 08:42:15 -0700 (PDT) Received: from [192.168.2.177] ([83.217.123.106]) by smtp.googlemail.com with ESMTPSA id bq7sm2656731wjc.31.2015.07.14.08.42.14 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 Jul 2015 08:42:14 -0700 (PDT) Message-ID: <55A52DD6.8040700@intel.com> Date: Tue, 14 Jul 2015 16:42:14 +0100 From: Michael Wood User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: "Barros Pena, Belen" References: <5596BB30.9040300@intel.com> In-Reply-To: Cc: "toaster@yoctoproject.org" Subject: Re: [review-request] michaelw/toaster/topnav X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jul 2015 15:42:20 -0000 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit WIP with the fixes (for design review only): michaelw/toaster/wip-nav-project-changes On 06/07/15 12:26, Barros Pena, Belen wrote: > * The 'Builds' tab should show only when the project has 1 or more builds. > Since showing the 'Configuration' tab on its own would be a bit weird, we > can leave as is for the moment until we add the 'My image recipes' tab Done > * The 'Builds' tab should link to the project builds page, not to the all > builds page Yeah it does link to the project builds page, however there is a server side exception redirect that does /project/x/build/ to /builds/ for some reason. https://bugzilla.yoctoproject.org/show_bug.cgi?id=7995 > > * In the breadcrumb we provide in the layer details page, the project name > should go to the 'Builds' tab when the number of builds in the project is > 1 or more, and to the 'Basic configuration' page when the number of builds > in the project is 0. Done > * Since we now have that beautiful global nav, we can remove the "Show all > builds" / "Show all projects" control in the all builds table. Done > > * In the build form, in the top right of the page, the help bubble inside > the 'build' button is not working (the tooltip doesn't show) Hm the tooltip event doesn't get triggered in firefox but does in chrome if it's inside a button element. I've moved it to the left of the input box as agreed. > > * We need to review the labels and headings across the pages in the the > left navigation: > > ** In the Bitbake variables page, the heading should say 'Bitbake > variables, should be a h2 and should not be wrapped in a page-header div Done > ** Until we implement the separation between the software recipes and the > image recipes, the label in the left navigation should simply say > "Recipes" instead of "Software recipes". The heading should say > "Compatible recipes" and should not be wrapped in a page-header div Done > > ** In the "Machines" page, the heading should say "Compatible machines" > and should not be wrapped in a page-header div Done > > ** In the "Layers" page, the heading should say "Compatible layers" and > should not be wrapped in a page-header div Done > > * In the recipes, machines and layers pages the placeholder text in the > search input field should match the headings above. Done > > * The recipes, machines and layers pages table content seems to be inside > the page-header div, which adds a grey line after the data table. Done (think that was fixed by ** #2) > > * In the Import layer page, the heading should be a h2 and should not be > wrapped in a page-header div. We can also remove the additional padding > left we are setting inline for the help text at the top, and for the > fieldset tag in line 182 of default.css. We can also remove the class > form-actions from the div with id form-actions and replace it with the > class air. That will left-align all form content nicely Done