From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46078) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZF2yb-0002UP-MJ for qemu-devel@nongnu.org; Tue, 14 Jul 2015 12:22:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZF2yX-00079B-K3 for qemu-devel@nongnu.org; Tue, 14 Jul 2015 12:22:37 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:41214) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZF2yX-00077u-Dc for qemu-devel@nongnu.org; Tue, 14 Jul 2015 12:22:33 -0400 Message-ID: <55A5373A.20806@imgtec.com> Date: Tue, 14 Jul 2015 17:22:18 +0100 From: Leon Alrae MIME-Version: 1.0 References: <1436868495-4359-1-git-send-email-leon.alrae@imgtec.com> <1436868495-4359-2-git-send-email-leon.alrae@imgtec.com> <20150714154536.GA7039@aurel32.net> In-Reply-To: <20150714154536.GA7039@aurel32.net> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] target-mips: fix logically dead code reported by Coverity List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno Cc: qemu-devel@nongnu.org On 14/07/2015 16:45, Aurelien Jarno wrote: > By the way, is this debug code really useful? I think by looking at the > TCG code (-d in_asm,op), it's easy to determine if an instruction is > correctly disassembled or not. > For me this debug code doesn't seem to be useful at all and it only clutters translate.c :) In this patch I just wanted to make Coverity happy so I followed the existing code but generally would vote for removal all of MIPS_DEBUG. Leon