All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Wood <michael.g.wood@intel.com>
To: "toaster@yoctoproject.org" <toaster@yoctoproject.org>
Subject: [review-request] michaelw/toastertable/sorting-cache-hit
Date: Tue, 14 Jul 2015 17:55:01 +0100	[thread overview]
Message-ID: <55A53EE5.4040906@intel.com> (raw)


poky-contrib branch: michaelw/toastertable/sorting-cache-hit

commit 548636b2c9a7be82bc098596c4e08ab156863e5b
Author: Michael Wood <michael.g.wood@intel.com>
Date:   Tue Jul 14 17:42:56 2015 +0100

     bitbake: toastergui: Toastertables don't replace dash in cache key

     The dash character was being stripped from the cache key when we 
sanitise
     it for the memcache backend. This meant that we were getting a 
false hit
     on the cache and returning non descending results which are 
indicated by
     the dash prefix on the field name.

     Signed-off-by: Michael Wood <michael.g.wood@intel.com>

diff --git a/bitbake/lib/toaster/toastergui/widgets.py 
b/bitbake/lib/toaster/toastergui/widgets.py
index 5f6b47b..0885402 100644
--- a/bitbake/lib/toaster/toastergui/widgets.py
+++ b/bitbake/lib/toaster/toastergui/widgets.py
@@ -252,8 +252,8 @@ class ToasterTable(TemplateView):
          for key, val in kwargs.iteritems():
              cache_name = cache_name + str(key) + str(val)

-        # No special chars allowed in the cache name
-        cache_name = re.sub(r'[^A-Za-z0-9]', "", cache_name)
+        # No special chars allowed in the cache name apart from dash
+        cache_name = re.sub(r'[^A-Za-z0-9-]', "", cache_name)
          data = cache.get(cache_name)

          if data:



             reply	other threads:[~2015-07-14 16:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-14 16:55 Michael Wood [this message]
2015-07-15 12:37 ` [review-request] michaelw/toastertable/sorting-cache-hit Damian, Alexandru
2015-07-28 13:41   ` Damian, Alexandru

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55A53EE5.4040906@intel.com \
    --to=michael.g.wood@intel.com \
    --cc=toaster@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.