From: Gustavo Zacarias <gustavo@zacarias.com.ar>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v5 1/6] Makefile: save MAKE_VERSION
Date: Tue, 14 Jul 2015 18:30:11 -0300 [thread overview]
Message-ID: <55A57F63.2080500@zacarias.com.ar> (raw)
In-Reply-To: <55A57DB3.4010806@mind.be>
On 14/07/15 18:22, Arnout Vandecappelle wrote:
>> +# Save running make version since it's clobbered by the make package
>> +RUNNING_MAKE_VERSION = $(MAKE_VERSION)
>
> Shouldn't this be := instead of = ? Otherwise it will still be clobbered, no?
>
> Otherwise:
> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
>
> Regards,
> Arnout
So very true!
I'll send v2, it can be applied separately, albeit before, webkit & minions.
Regards.
next prev parent reply other threads:[~2015-07-14 21:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-14 19:42 [Buildroot] [PATCH v5 0/6] The big webkitgtk bump Gustavo Zacarias
2015-07-14 19:42 ` [Buildroot] [PATCH v5 1/6] Makefile: save MAKE_VERSION Gustavo Zacarias
2015-07-14 21:22 ` Arnout Vandecappelle
2015-07-14 21:30 ` Gustavo Zacarias [this message]
2015-07-14 19:42 ` [Buildroot] [PATCH v5 2/6] webkitgtk24: new package Gustavo Zacarias
2015-07-14 19:42 ` [Buildroot] [PATCH v5 3/6] midori: bump to version 0.5.9 Gustavo Zacarias
2015-07-14 19:42 ` [Buildroot] [PATCH v5 4/6] vala: bump to version 0.28.0 Gustavo Zacarias
2015-07-14 21:54 ` Thomas Petazzoni
2015-07-14 22:12 ` Gustavo Zacarias
2015-07-14 22:27 ` Thomas Petazzoni
2015-07-14 19:42 ` [Buildroot] [PATCH v5 5/6] webkit: mark as deprecated Gustavo Zacarias
2015-07-14 19:42 ` [Buildroot] [PATCH v5 6/6] libgail: " Gustavo Zacarias
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A57F63.2080500@zacarias.com.ar \
--to=gustavo@zacarias.com.ar \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.