From: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
To: Bjorn Helgaas <bhelgaas@google.com>, linux-pci@vger.kernel.org
Cc: Myron Stowe <myron.stowe@redhat.com>, Jiang Liu <jiang.liu@huawei.com>
Subject: Re: [PATCH 1/2] PCI: Fix pcie_port_device_resume() comment
Date: Wed, 15 Jul 2015 00:25:05 +0200 [thread overview]
Message-ID: <55A58C41.9000804@intel.com> (raw)
In-Reply-To: <20150714194503.13471.65928.stgit@bhelgaas-glaptop2.roam.corp.google.com>
On 7/14/2015 9:45 PM, Bjorn Helgaas wrote:
> The function comment claimed this was pcie_port_device_suspend(), but it's
> really pcie_port_device_resume(). Perils of cut and paste.
>
> Use the correct function name in the comment.
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
ACK
> ---
> drivers/pci/pcie/portdrv_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/pcie/portdrv_core.c b/drivers/pci/pcie/portdrv_core.c
> index 2f0ce66..88122dc 100644
> --- a/drivers/pci/pcie/portdrv_core.c
> +++ b/drivers/pci/pcie/portdrv_core.c
> @@ -448,7 +448,7 @@ static int resume_iter(struct device *dev, void *data)
> }
>
> /**
> - * pcie_port_device_suspend - resume port services associated with a PCIe port
> + * pcie_port_device_resume - resume port services associated with a PCIe port
> * @dev: PCI Express port to handle
> */
> int pcie_port_device_resume(struct device *dev)
>
next prev parent reply other threads:[~2015-07-14 22:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-14 19:44 [PATCH 0/2] PCI: Comment and PCIe capability accessor fixes Bjorn Helgaas
2015-07-14 19:45 ` [PATCH 1/2] PCI: Fix pcie_port_device_resume() comment Bjorn Helgaas
2015-07-14 22:25 ` Rafael J. Wysocki [this message]
2015-07-14 19:45 ` [PATCH 2/2] PCI: Add pcie_downstream_port() (true for Root and Switch Downstream Ports) Bjorn Helgaas
2015-07-14 22:26 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A58C41.9000804@intel.com \
--to=rafael.j.wysocki@intel.com \
--cc=bhelgaas@google.com \
--cc=jiang.liu@huawei.com \
--cc=linux-pci@vger.kernel.org \
--cc=myron.stowe@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.