All of lore.kernel.org
 help / color / mirror / Atom feed
From: Qu Wenruo <quwenruo@cn.fujitsu.com>
To: <dsterba@suse.com>, <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] Revert "btrfs-progs: mkfs: create only desired block groups for single device"
Date: Wed, 15 Jul 2015 08:40:44 +0800	[thread overview]
Message-ID: <55A5AC0C.8080602@cn.fujitsu.com> (raw)
In-Reply-To: <20150714114511.GG15535@twin.jikos.cz>



David Sterba wrote on 2015/07/14 13:45 +0200:
> On Tue, Jul 14, 2015 at 10:13:01AM +0800, Qu Wenruo wrote:
>> This reverts commit 5f8232e5c8f0b0de0ef426274911385b0e877392.
>
> Thanks.  The revert is justified for the severity of the problem, I'll
> release 4.1.2 asap.
>
>> This commit causes a regression:
>> ---
>
> BTW, do not use --- in the changelog as 'git am' will ignore the text
> between that and the diff.
>
Oh, sorry I forgot that "---" will be ignored by git.
Next time I'll use "===" to avoid such careless problem.

BTW, for the mkfs test case, it will be delayed for a while as the 
following bugs are making things quite tricky.

1) fsck ignore chunk errors and return 0.
Cause is known and easy to fix, but if fixed, most of fsck test won't pass.
As the following bug is causing problem.

2) btrfs-image restore bug, causing missing dev_extent for DUP chunk.
Investigating. that's the reason causing a lot of dev extent missing in 
mkfs test.
And thanks to the previous bug, we can pass fsck test like a miracle.

So I'm afraid the corresponding regression test case won't be in time 
with 4.1.2 hotfix release.

Thanks,
Qu

  reply	other threads:[~2015-07-15  0:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-14  2:13 [PATCH] Revert "btrfs-progs: mkfs: create only desired block groups for single device" Qu Wenruo
2015-07-14 11:45 ` David Sterba
2015-07-15  0:40   ` Qu Wenruo [this message]
2015-07-15 11:33     ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55A5AC0C.8080602@cn.fujitsu.com \
    --to=quwenruo@cn.fujitsu.com \
    --cc=dsterba@suse.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.