From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tang Chen Subject: Re: [PATCH 3/5] x86, acpi, cpu-hotplug: Introduce apicid_to_cpuid[] array to store persistent cpuid <-> apicid mapping. Date: Wed, 15 Jul 2015 14:26:12 +0800 Message-ID: <55A5FD04.1090003@cn.fujitsu.com> References: <1436261425-29881-1-git-send-email-tangchen@cn.fujitsu.com> <1436261425-29881-4-git-send-email-tangchen@cn.fujitsu.com> <55A5D4A5.8040806@cn.fujitsu.com> <55A5F109.3020705@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from cn.fujitsu.com ([59.151.112.132]:48894 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1750772AbbGOGZb convert rfc822-to-8bit (ORCPT ); Wed, 15 Jul 2015 02:25:31 -0400 In-Reply-To: <55A5F109.3020705@linux.intel.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Jiang Liu , =?UTF-8?B?TWlrYSBQZW50dGlsw6Q=?= Cc: rjw@rjwysocki.net, gongzhaogang@inspur.com, x86@kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org On 07/15/2015 01:35 PM, Jiang Liu wrote: > On 2015/7/15 11:33, Tang Chen wrote: >> Hi Mika, >> >> On 07/07/2015 07:14 PM, Mika Penttil=C3=A4 wrote: >>> I think you forgot to reserve CPU 0 for BSP in cpuid mask. >> Sorry for the late reply. >> >> I'm not familiar with BSP. Do you mean in get_cpuid(), >> I should reserve 0 for physical cpu0 in BSP ? >> >> Would you please share more detail ? > BSP stands for "Bootstrapping Processor". In other word, > BSP is CPU0. > . > Ha, how foolish I am. And yes, cpu0 is not reserved when apicid =3D=3D boot_cpu_physical_apic= id comes true. Will update the patch. Thanks. :) -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f179.google.com (mail-pd0-f179.google.com [209.85.192.179]) by kanga.kvack.org (Postfix) with ESMTP id E365728027E for ; Wed, 15 Jul 2015 02:25:31 -0400 (EDT) Received: by pdbep18 with SMTP id ep18so19877255pdb.1 for ; Tue, 14 Jul 2015 23:25:31 -0700 (PDT) Received: from heian.cn.fujitsu.com ([59.151.112.132]) by mx.google.com with ESMTP id go6si5717911pbc.237.2015.07.14.23.25.29 for ; Tue, 14 Jul 2015 23:25:30 -0700 (PDT) Message-ID: <55A5FD04.1090003@cn.fujitsu.com> Date: Wed, 15 Jul 2015 14:26:12 +0800 From: Tang Chen MIME-Version: 1.0 Subject: Re: [PATCH 3/5] x86, acpi, cpu-hotplug: Introduce apicid_to_cpuid[] array to store persistent cpuid <-> apicid mapping. References: <1436261425-29881-1-git-send-email-tangchen@cn.fujitsu.com> <1436261425-29881-4-git-send-email-tangchen@cn.fujitsu.com> <55A5D4A5.8040806@cn.fujitsu.com> <55A5F109.3020705@linux.intel.com> In-Reply-To: <55A5F109.3020705@linux.intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable Sender: owner-linux-mm@kvack.org List-ID: To: Jiang Liu , =?UTF-8?B?TWlrYSBQZW50dGlsw6Q=?= Cc: rjw@rjwysocki.net, gongzhaogang@inspur.com, x86@kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org On 07/15/2015 01:35 PM, Jiang Liu wrote: > On 2015/7/15 11:33, Tang Chen wrote: >> Hi Mika, >> >> On 07/07/2015 07:14 PM, Mika Penttil=C3=A4 wrote: >>> I think you forgot to reserve CPU 0 for BSP in cpuid mask. >> Sorry for the late reply. >> >> I'm not familiar with BSP. Do you mean in get_cpuid(), >> I should reserve 0 for physical cpu0 in BSP ? >> >> Would you please share more detail ? > BSP stands for "Bootstrapping Processor". In other word, > BSP is CPU0. > . > Ha, how foolish I am. And yes, cpu0 is not reserved when apicid =3D=3D boot_cpu_physical_apicid comes true. Will update the patch. Thanks. :) -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751894AbbGOGZd (ORCPT ); Wed, 15 Jul 2015 02:25:33 -0400 Received: from cn.fujitsu.com ([59.151.112.132]:48894 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1750772AbbGOGZb convert rfc822-to-8bit (ORCPT ); Wed, 15 Jul 2015 02:25:31 -0400 X-IronPort-AV: E=Sophos;i="5.13,665,1427731200"; d="scan'208";a="98460422" Message-ID: <55A5FD04.1090003@cn.fujitsu.com> Date: Wed, 15 Jul 2015 14:26:12 +0800 From: Tang Chen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: Jiang Liu , =?UTF-8?B?TWlrYSBQZW50dGlsw6Q=?= CC: , , , , , Subject: Re: [PATCH 3/5] x86, acpi, cpu-hotplug: Introduce apicid_to_cpuid[] array to store persistent cpuid <-> apicid mapping. References: <1436261425-29881-1-git-send-email-tangchen@cn.fujitsu.com> <1436261425-29881-4-git-send-email-tangchen@cn.fujitsu.com> <55A5D4A5.8040806@cn.fujitsu.com> <55A5F109.3020705@linux.intel.com> In-Reply-To: <55A5F109.3020705@linux.intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/15/2015 01:35 PM, Jiang Liu wrote: > On 2015/7/15 11:33, Tang Chen wrote: >> Hi Mika, >> >> On 07/07/2015 07:14 PM, Mika Penttilä wrote: >>> I think you forgot to reserve CPU 0 for BSP in cpuid mask. >> Sorry for the late reply. >> >> I'm not familiar with BSP. Do you mean in get_cpuid(), >> I should reserve 0 for physical cpu0 in BSP ? >> >> Would you please share more detail ? > BSP stands for "Bootstrapping Processor". In other word, > BSP is CPU0. > . > Ha, how foolish I am. And yes, cpu0 is not reserved when apicid == boot_cpu_physical_apicid comes true. Will update the patch. Thanks. :)