From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33586) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZFI8F-00026U-JN for qemu-devel@nongnu.org; Wed, 15 Jul 2015 04:33:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZFI8A-0005Tl-Os for qemu-devel@nongnu.org; Wed, 15 Jul 2015 04:33:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47007) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZFI8A-0005TZ-Ju for qemu-devel@nongnu.org; Wed, 15 Jul 2015 04:33:30 -0400 References: <1436432462-28023-1-git-send-email-lizhijian@cn.fujitsu.com> <87r3o9bz50.fsf@neno.neno> From: Paolo Bonzini Message-ID: <55A61AD4.1040209@redhat.com> Date: Wed, 15 Jul 2015 10:33:24 +0200 MIME-Version: 1.0 In-Reply-To: <87r3o9bz50.fsf@neno.neno> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] migration: use call_rcu instead of synchronize_rcu List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: quintela@redhat.com, Li Zhijian Cc: amit.shah@redhat.com, qemu-devel@nongnu.org On 15/07/2015 10:31, Juan Quintela wrote: > Li Zhijian wrote: >> > from commit 2ff6403, we make a mistake to call synchronize_rcu() >> > within rcu_read_lock()/rcu_read_unlock() >> > >> > Signed-off-by: Li Zhijian >> > Signed-off-by: Wen Congyang >> > Signed-off-by: Li Zhijian > Hi > > my understanding is that commit > d09a6fde1590ca3a45b608b6873a680f208dfeb5 > > from Paolo already fixed this, right? > > Not that I am against the change. Should I still pull it? I think it's unnecessary complication. Paolo