All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy@intel.com>
To: damu <2103458176@qq.com>
Cc: dev <dev@dpdk.org>
Subject: Re: App crash when using no-huge option
Date: Wed, 15 Jul 2015 10:57:07 +0100	[thread overview]
Message-ID: <55A62E73.8060503@intel.com> (raw)
In-Reply-To: <tencent_06BE1BD20BEC88F81E937905@qq.com>

On 15/07/2015 08:34, damu wrote:
> Hi,
>
> Today I tried no-huge option with app/test, the test app crashed.
> It seems that memory can not be allocated.
> I think it could be this change causing the panic. Can someone check it?
>
>
Hi Damu,

Actually it is the following commit causing the panic:

commit b3dfffd962ecd7a1d8700193b4b3305dc85e7ae4
Author: Cyril Chemparathy <cchemparathy@ezchip.com>
Date:   Thu Jul 9 16:25:15 2015 +0800

     mem: allow multiple page sizes to be requested

Cause is that since allowing multiple page sizes it always expects the 
hugepage_sz
field to be set to a value, but when using --no-huge, the field 
hugepage_sz is 0 and
the logic does not work as expected.

The issue could be fixed but adding logic to expect hugepage_sz being 0 
or by setting
hugepage_sz to a value (RTE_PGSIZE_4K) when using --no-huge.

The latter would be my preference. I'll send a patch fixing it.

Sergio

  reply	other threads:[~2015-07-15  9:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-15  7:34 App crash when using no-huge option damu
2015-07-15  9:57 ` Gonzalez Monroy, Sergio [this message]
2015-07-15 10:12 ` [PATCH] eal: set hugepgae_sz to 4KB when using --no-huge Sergio Gonzalez Monroy
2015-07-15 12:29   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55A62E73.8060503@intel.com \
    --to=sergio.gonzalez.monroy@intel.com \
    --cc=2103458176@qq.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.