From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 5D564E009B8; Wed, 15 Jul 2015 03:52:29 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [74.125.82.50 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Received: from mail-wg0-f50.google.com (mail-wg0-f50.google.com [74.125.82.50]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 7EFCEE009B2 for ; Wed, 15 Jul 2015 03:52:23 -0700 (PDT) Received: by wgkl9 with SMTP id l9so30271849wgk.1 for ; Wed, 15 Jul 2015 03:52:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=gXxWrBhK7d2RLZp52nbJ4gelEcf1rQLZjiOmEjR+4Nc=; b=HPudfGhOExRv7vrvvObbxSQMEGlIHrm6AH3CxYEneX5YK7WrQ87EOrWrT2C6UC+P4J ctr1OQHDwTPe3lMFZPBienUNnMhwMuZg9+15E28GiUsERbzn2OnTTIRxhS4tYYRYVMI7 BFg4bK2pegWngA1UpZpQDEJKWXMzieOA1cm56XmUHkiy+qB/0pBVCSQvNlGgwXpyinTA DT7DmQxcAMr5MhQB4zRXzb7G4+jlRm/lHbERHeZNXpczeAuK+C41B9C69iV+DCZOFwJo OI9eROQapMurjhF8wF8nCdYDA1XuvDvn2GHIWEBDrC00m7nt+vYSV+LnpO7sWTJlk6hS 2sBA== X-Gm-Message-State: ALoCoQlOVo9l/gsjfJZT1EA0FdBi1RHIgZ7uERG5hN1o/1/CNd0j1iQj25+NvXX5lypROgG4s7Ru X-Received: by 10.180.84.202 with SMTP id b10mr15129057wiz.23.1436957543214; Wed, 15 Jul 2015 03:52:23 -0700 (PDT) Received: from [192.168.2.157] ([83.217.123.106]) by smtp.googlemail.com with ESMTPSA id bq7sm7292132wjc.31.2015.07.15.03.52.21 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 Jul 2015 03:52:22 -0700 (PDT) Message-ID: <55A63B65.6070807@intel.com> Date: Wed, 15 Jul 2015 11:52:21 +0100 From: Michael Wood User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: toaster@yoctoproject.org References: <1436907991-18361-1-git-send-email-brian.avery@intel.com> In-Reply-To: <1436907991-18361-1-git-send-email-brian.avery@intel.com> Subject: Re: [review-request][PATCH] bitbake: toaster: do not stop data import on bad data X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jul 2015 10:52:29 -0000 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit On 14/07/15 22:06, Brian Avery wrote: > Continue storing layers in the database even if we hit > a bad layer. > > [YOCTO #7955] > --- > bitbake/lib/toaster/orm/models.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/bitbake/lib/toaster/orm/models.py b/bitbake/lib/toaster/orm/models.py > index 4ea75f2..c218198 100644 > --- a/bitbake/lib/toaster/orm/models.py > +++ b/bitbake/lib/toaster/orm/models.py > @@ -891,7 +891,7 @@ class LayerIndexLayerSource(LayerSource): > dependlist[lv].append(Layer_Version.objects.get(layer_source = self, layer__up_id = ldi['dependency'], up_branch = lv.up_branch)) > except Layer_Version.DoesNotExist as e: > print "Cannot find layer version ", self, ldi['dependency'], lv.up_branch > - raise e > + pass > > for lv in dependlist: > LayerVersionDependency.objects.filter(layer_version = lv).delete() You can also remove the variable "e" to avoid an unused variable warning here. (pylint will pick this up https://wiki.yoctoproject.org/wiki/Contribute_to_Toaster#Python )