Re: [Qemu-devel] [ARM SMBIOS RFC PATCH 4/5] smbios: move smbios code into a common folder

[Laszlo Ersek <lersek@redhat.com>]

On 07/14/15 22:23, Wei Huang wrote:
> To share smbios among different architectures, this patch moves SMBIOS
> code (smbios.c and smbios.h) from x86 specific folders into new
> hw/smbios directories. As a result, CONFIG_SMBIOS=y is defined in
> x86 default config files.
> 
> Signed-off-by: Wei Huang <wei@redhat.com>
> ---
>  arch_init.c                        |    2 +-
>  default-configs/i386-softmmu.mak   |    1 +
>  default-configs/x86_64-softmmu.mak |    1 +
>  hw/Makefile.objs                   |    1 +
>  hw/i386/Makefile.objs              |    2 +-
>  hw/i386/pc.c                       |    2 +-
>  hw/i386/pc_piix.c                  |    2 +-
>  hw/i386/pc_q35.c                   |    2 +-
>  hw/i386/smbios.c                   | 1102 ------------------------------------
>  hw/smbios/Makefile.objs            |    1 +
>  hw/smbios/smbios.c                 | 1102 ++++++++++++++++++++++++++++++++++++
>  include/hw/i386/smbios.h           |  237 --------
>  include/hw/smbios/smbios.h         |  237 ++++++++
>  tests/bios-tables-test.c           |    2 +-
>  vl.c                               |    2 +-
>  15 files changed, 1350 insertions(+), 1346 deletions(-)
>  delete mode 100644 hw/i386/smbios.c
>  create mode 100644 hw/smbios/Makefile.objs
>  create mode 100644 hw/smbios/smbios.c
>  delete mode 100644 include/hw/i386/smbios.h
>  create mode 100644 include/hw/smbios/smbios.h

Can you please send the next version of this series (I assume there's
going to be one) with rename detection enabled? At least
"hw/i386/smbios.c" --> "hw/smbios/smbios.c" appears a rename. A few
lines may have changed, but without enabling rename detection, it's
really hard to tell.

Thanks
Laszlo