From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: Regression in OSSTest Windows install test case Date: Wed, 15 Jul 2015 15:43:09 +0100 Message-ID: <55A6717D.9070900@citrix.com> References: <20150715144029.GC12455@zion.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZFNu8-0005Qo-VZ for xen-devel@lists.xenproject.org; Wed, 15 Jul 2015 14:43:25 +0000 In-Reply-To: <20150715144029.GC12455@zion.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu , xen-devel@lists.xenproject.org Cc: Paul Durrant , Jan Beulich List-Id: xen-devel@lists.xenproject.org On 15/07/15 15:40, Wei Liu wrote: > Hi all > > The Windows install test case has been failing reliably in OSSTest for > the last 6 runs. > > The issue manifest as Windows hit blue screen with garbled text that > cannot be recognised when booting. Xen doesn't complain about any > failures. > > I bisected that and found this commit is to be blamed. > > commit 3bbaaec09b1b942f5624dee176da6e416d31f982 > Author: Paul Durrant > Date: Thu Jul 9 19:04:00 2015 +0200 > > x86/hvm: unify stdvga mmio intercept with standard mmio intercept > > It's clear from the following check in hvmemul_rep_movs: > > if ( sp2mt == p2m_mmio_direct || dp2mt == p2m_mmio_direct || > (sp2mt == p2m_mmio_dm && dp2mt == p2m_mmio_dm) ) > return X86EMUL_UNHANDLEABLE; > > that mmio <-> mmio copy is not handled. This means the code in the > stdvga mmio intercept that explicitly handles mmio <-> mmio copy when > hvm_copy_to/from_guest_phys() fails is never going to be executed. > > This patch therefore adds a check in hvmemul_do_io_addr() to make sure > mmio <-> mmio is disallowed and then registers standard mmio intercept ops > in stdvga_init(). > > With this patch all mmio and portio handled within Xen now goes through > process_io_intercept(). > > Signed-off-by: Paul Durrant > Reviewed-by: Andrew Cooper > > Tell me if you need more information or want me to test a patch. I do > have test environment at hand. Given the nature of the patch, I would not be unduly surprised that the text is garbled. Which windows and qemu are you using? We have not encountered a single failure like this in XenServer testing. ~Andrew