From: Tadeusz Struk <tadeusz.struk@intel.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-crypto@vger.kernel.org, qat-linux@intel.com,
pingchao.yang@intel.com, davem@davemloft.net
Subject: Re: [PATCH v2 3/3] crypto: qat - Add support for RSA algorithm
Date: Wed, 15 Jul 2015 08:14:51 -0700 [thread overview]
Message-ID: <55A678EB.4020604@intel.com> (raw)
In-Reply-To: <20150715150939.GA3347@gondor.apana.org.au>
On 07/15/2015 08:09 AM, Herbert Xu wrote:
>> This is even more complicated because the user can first allocate request
>> > and then call setkey causing fallback. I'm now thinking about adding the
>> > limitation to rsa generic or I can still use rsa-generic which I know that
>> > its ctx is smaller than mine. What do you think?
> This would preclude any future assembly implementations from being
> used. Besides this is how we implement fallbacks everywhere else
> in the crypto API so I don't see why this one should be different.
Are you ok if I just add the same constrains to rsa-generic?
>
>> The rsa_parse_key helper in the rsa generic that parses the key in BER format
>> > produces the MPIs.I didn't want to add yet another BER parser here. Should I?
> I don't see why not. Certainly beats having to go in and out of
> MPIs.
Ok will do that.
Thanks,
T
next prev parent reply other threads:[~2015-07-15 15:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-14 18:32 [PATCH v2 0/3] crypto: qat - add RSA support to qat driver Tadeusz Struk
2015-07-14 18:32 ` [PATCH v2 1/3] crypto: qat - add support for MMP FW Tadeusz Struk
2015-07-14 18:32 ` [PATCH v2 2/3] crypto: qat - add MMP FW support to accel engine Tadeusz Struk
2015-07-14 18:33 ` [PATCH v2 3/3] crypto: qat - Add support for RSA algorithm Tadeusz Struk
2015-07-15 13:03 ` Herbert Xu
2015-07-15 15:05 ` Tadeusz Struk
2015-07-15 15:09 ` Herbert Xu
2015-07-15 15:14 ` Tadeusz Struk [this message]
2015-07-15 15:16 ` Herbert Xu
2015-07-15 15:19 ` Tadeusz Struk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A678EB.4020604@intel.com \
--to=tadeusz.struk@intel.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=pingchao.yang@intel.com \
--cc=qat-linux@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.