From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yang Hongyang Subject: Re: [PATCH v4 --for 4.6 COLOPre 24/25] tools/libxl: move remus state into a seperate structure Date: Wed, 15 Jul 2015 23:18:53 +0800 Message-ID: <55A679DD.3010601@cn.fujitsu.com> References: <1436946351-21118-1-git-send-email-yanghy@cn.fujitsu.com> <1436946351-21118-25-git-send-email-yanghy@cn.fujitsu.com> <21926.30546.78207.256971@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <21926.30546.78207.256971@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: wei.liu2@citrix.com, ian.campbell@citrix.com, wency@cn.fujitsu.com, andrew.cooper3@citrix.com, yunhong.jiang@intel.com, eddie.dong@intel.com, xen-devel@lists.xen.org, guijianfeng@cn.fujitsu.com, rshriram@cs.ubc.ca List-Id: xen-devel@lists.xenproject.org On 07/15/2015 11:08 PM, Ian Jackson wrote: > Yang Hongyang writes ("[Xen-devel] [PATCH v4 --for 4.6 COLOPre 24/25] tools/libxl: move remus state into a seperate structure"): >> Add a new structure remus state, and move concrete layer's private >> member to remus state. >> it is pure refactoring and no functional changes. > > Thanks. I don't have much to add to what Ian Campbell has said, but > >> if (dss->checkpointed_stream == LIBXL_CHECKPOINTED_STREAM_REMUS) { >> - dss->interval = r_info->interval; >> if (libxl_defbool_val(r_info->compression)) >> dss->xcflags |= XCFLAGS_CHECKPOINT_COMPRESS; > > In your next version it would be worth mentioning the movement of this > initialisation in the commit message. Ok, thanks! > > Ian. > . > -- Thanks, Yang.