From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60047)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Leon.Alrae@imgtec.com>) id 1ZFP0l-0005VK-Bi
	for qemu-devel@nongnu.org; Wed, 15 Jul 2015 11:54:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Leon.Alrae@imgtec.com>) id 1ZFP0h-0003q2-90
	for qemu-devel@nongnu.org; Wed, 15 Jul 2015 11:54:19 -0400
Received: from mailapp01.imgtec.com ([195.59.15.196]:36577)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Leon.Alrae@imgtec.com>) id 1ZFP0h-0003pv-39
	for qemu-devel@nongnu.org; Wed, 15 Jul 2015 11:54:15 -0400
Message-ID: <55A6821E.8080306@imgtec.com>
Date: Wed, 15 Jul 2015 16:54:06 +0100
From: Leon Alrae <leon.alrae@imgtec.com>
MIME-Version: 1.0
References: <0DA23CC379F5F945ACB41CF394B98277210E9658@LEMAIL01.le.imgtec.org>
	<55929712.4090509@imgtec.com>
In-Reply-To: <55929712.4090509@imgtec.com>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] linux-user: Fix MIPS N64 trap and break
 instruction bug
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andrew Bennett <Andrew.Bennett@imgtec.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: Riku Voipio <riku.voipio@iki.fi>

On 30/06/2015 14:18, Leon Alrae wrote:
> On 29/06/2015 11:20, Andrew Bennett wrote:
>> From: Andrew Bennett <andrew.bennett@imgtec.com>
>>
>> For the MIPS N64 ABI when QEMU reads the break/trap instruction so that
>> it can inspect the break/trap code it reads 8 rather than 4 bytes
>> which means it finds the code field from the instruction after the 
>> break/trap instruction.  This then causes the break/trap handling
>> code to fail because it does not understand the code number.
>>
>> The fix forces QEMU to always read 4 bytes of instruction data rather
>> than deciding how much to read based on the ABI.
>>
>> Signed-off-by: Andrew Bennett <andrew.bennett@imgtec.com>
>> ---
>>  linux-user/main.c |    4 ++--
>>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> Reviewed-by: Leon Alrae <leon.alrae@imgtec.com>

Riku, I'm including this patch in target-mips queue which I'm going to send
out soon for rc1. If you have any objections please let me know.

Thanks,
Leon