From mboxrd@z Thu Jan 1 00:00:00 1970 From: axboe@fb.com (Jens Axboe) Date: Wed, 15 Jul 2015 15:36:17 -0600 Subject: [PATCH] NVMe: Reread partitions on metadata formats In-Reply-To: References: <1436896668-27373-1-git-send-email-keith.busch@intel.com> <55A559B5.2000303@fb.com> Message-ID: <55A6D251.9050801@fb.com> On 07/14/2015 09:48 PM, Dan Williams wrote: > On Tue, Jul 14, 2015@11:49 AM, Jens Axboe wrote: >> On 07/14/2015 11:57 AM, Keith Busch wrote: >>> >>> This patch has the driver automatically reread partitions if a namespace >>> has a separate metadata format. Previously revalidating a disk was >>> sufficient to get the correct capacity set on such formatted drives, >>> but partitions that may exist would not have been surfaced. >> >> >> Looks sane to me. Paul, does this fix your issue? > > NVDIMM namespaces with metadata space will run into this same problem. > Why not make revalidate_disk re-read partitions? Yeah that's a good point, we should try that. I'll queue up Keith's fix for now since it's fixing a real bug, then we can revisit and kill it later. -- Jens Axboe